-
-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): run all types of async validation on fields during submit #852
fix(core): run all types of async validation on fields during submit #852
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 7b5072c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
058262c
to
f14041d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #852 +/- ##
==========================================
- Coverage 91.55% 88.19% -3.36%
==========================================
Files 21 26 +5
Lines 900 932 +32
Branches 206 209 +3
==========================================
- Hits 824 822 -2
- Misses 71 102 +31
- Partials 5 8 +3 ☔ View full report in Codecov by Sentry. |
f14041d
to
b23ef65
Compare
I don't know how to fix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fix was included in #656 but the test remains valid, I'm merging it. Thanks!
fix #851
In
validateSync
function,validateObj.cause
is used instead ofcause
. I think they should be same.