Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): run all types of async validation on fields during submit #852

Merged

Conversation

fkworld
Copy link
Contributor

@fkworld fkworld commented Jul 12, 2024

fix #851

In validateSync function, validateObj.cause is used instead of cause. I think they should be same.

Copy link

nx-cloud bot commented Jul 12, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 7b5072c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

Copy link

pkg-pr-new bot commented Jul 12, 2024

Open in Stackblitz

More templates

@tanstack/angular-form

pnpm add https://pkg.pr.new/@tanstack/angular-form@852

@tanstack/form-core

pnpm add https://pkg.pr.new/@tanstack/form-core@852

@tanstack/lit-form

pnpm add https://pkg.pr.new/@tanstack/lit-form@852

@tanstack/solid-form

pnpm add https://pkg.pr.new/@tanstack/solid-form@852

@tanstack/react-form

pnpm add https://pkg.pr.new/@tanstack/react-form@852

@tanstack/valibot-form-adapter

pnpm add https://pkg.pr.new/@tanstack/valibot-form-adapter@852

@tanstack/vue-form

pnpm add https://pkg.pr.new/@tanstack/vue-form@852

@tanstack/yup-form-adapter

pnpm add https://pkg.pr.new/@tanstack/yup-form-adapter@852

@tanstack/zod-form-adapter

pnpm add https://pkg.pr.new/@tanstack/zod-form-adapter@852

commit: 7b5072c

@fkworld fkworld force-pushed the fix-submit-trigger-async-validators branch from 058262c to f14041d Compare July 12, 2024 08:43
Copy link

codecov bot commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.19%. Comparing base (5473bb8) to head (b23ef65).
Report is 69 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #852      +/-   ##
==========================================
- Coverage   91.55%   88.19%   -3.36%     
==========================================
  Files          21       26       +5     
  Lines         900      932      +32     
  Branches      206      209       +3     
==========================================
- Hits          824      822       -2     
- Misses         71      102      +31     
- Partials        5        8       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fkworld fkworld force-pushed the fix-submit-trigger-async-validators branch from f14041d to b23ef65 Compare July 25, 2024 09:15
@fkworld
Copy link
Contributor Author

fkworld commented Jul 25, 2024

I don't know how to fix codecov/project failed.

Copy link
Member

@Balastrong Balastrong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix was included in #656 but the test remains valid, I'm merging it. Thanks!

@Balastrong Balastrong merged commit 01ef0a1 into TanStack:main Oct 1, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

form submit not trigger validators.onChangeAsync
2 participants