Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issues with StrictMode and arrays are now solved #771

Merged
merged 4 commits into from
Jun 22, 2024

Conversation

crutchcorn
Copy link
Member

@crutchcorn crutchcorn commented Jun 22, 2024

This PR solves issues with StrictMode and arrays as outlined by #704.

Fixes #704

TODO

  • React tests for currently failing edgecase

Copy link

nx-cloud bot commented Jun 22, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 1678f84. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@crutchcorn crutchcorn force-pushed the fix-strict-mode-dual-render-issue branch from 4ca577f to ab4dadf Compare June 22, 2024 17:27
@crutchcorn crutchcorn marked this pull request as ready for review June 22, 2024 17:47
@crutchcorn crutchcorn changed the title [WIP] fix: issues with StrictMode and arrays are now solved fix: issues with StrictMode and arrays are now solved Jun 22, 2024
Copy link

codecov bot commented Jun 22, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 91.41%. Comparing base (5473bb8) to head (1678f84).

Files Patch % Lines
packages/form-core/src/FieldApi.ts 66.66% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #771      +/-   ##
==========================================
- Coverage   91.55%   91.41%   -0.15%     
==========================================
  Files          21       21              
  Lines         900      920      +20     
  Branches      206      218      +12     
==========================================
+ Hits          824      841      +17     
- Misses         71       74       +3     
  Partials        5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crutchcorn crutchcorn merged commit 4e54c09 into main Jun 22, 2024
3 of 4 checks passed
@crutchcorn crutchcorn deleted the fix-strict-mode-dual-render-issue branch June 22, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nested Values Disappear when using StrictMode and pushValue
1 participant