Upgrade to Python 3.9 and Django 4.0 #1952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Involves consequential compatibility changes: https://channels.readthedocs.io/en/stable/releases/3.0.0.html
Bumps [django](https://github.com/django/django) from 3.2.9 to 4.0. - [Release notes](https://github.com/django/django/releases) - [Commits](django/django@3.2.9...4.0) --- updated-dependencies: - dependency-name: django dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
(Django 4.0 only supports Python 3.8 and later)
|
Okay, I think we're there!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't work yet.
Two sticking points:
The
django-jetlibrary is incompatible in several places with Django 4.0. I've had a crack to see if the fixes are trivial in czlee/django-jet, and might submit a PR to RamsesMartinez/django-jet if they work out. But otherwise we might need to find another solution again—see Upgrade Python to 3.8.2 and Django to 3.0.7 #1507 for the last time we discussed this.channelsrequiresasgiref<3.4, but Django 4.0 requiresasgiref>=3.4.1. This is a known issue, see [RuntimeError: no running event loop] with runworker in channels 2.3.1 with latest asgiref (3.4.0) django/channels#1713.We can't stay on
channels==2.4.0, because it's also not compatible with Django 4.0 (becauseLANGUAGE_SESSION_KEYwas removed; this has been fixed inchannels). So we're currently blocked by django/channels 1713.This includes:
(The tests pass, but
npm run servedoes not.)