Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vscode): support attach files in inline chat #3231

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

eryue0220
Copy link
Contributor

Fix: #2964

Screen.Recording.2024-10-02.at.18.04.12.mov

@wsxiaoys
Copy link
Member

wsxiaoys commented Oct 4, 2024

Note #2964 actually pertains to adding file context to the "inline editor" functionality (cmd-i "Tabby: Start Inline Editing"). However, the interaction appears to be great!

Could you modify the functionality to support inline editing? We don't really need it for the side panel since we can add file context by opening the file directly.

@eryue0220
Copy link
Contributor Author

Note #2964 actually pertains to adding file context to the "inline editor" functionality (cmd-i "Tabby: Start Inline Editing"). However, the interaction appears to be great!

Could you modify the functionality to support inline editing? We don't really need it for the side panel since we can add file context by opening the file directly.

Oh sorry, I missed that, I'll fix it later.

@eryue0220 eryue0220 marked this pull request as draft October 6, 2024 07:23
@eryue0220 eryue0220 marked this pull request as ready for review October 11, 2024 09:59
@wsxiaoys wsxiaoys changed the title feat(vscode): support file attach feat(vscode): support attach files in inline chat Oct 14, 2024
@eryue0220
Copy link
Contributor Author

Updated:

record.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[VSCode] Allow attaching file context to inline editor
2 participants