Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go directory up if no Index.html is found #212

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

linawolf
Copy link
Contributor

@linawolf linawolf commented Dec 10, 2024

This prevent showing the 404 message and instead gives better results. It also prevents us from having to create orphan Index.rst files in folders that are directly integrated into menues and have no logical index.

https://docs.typo3.org/m/typo3/reference-coreapi/13.4/en-us/Administration/Installation/Environments/Index.html

Would redirect to

https://docs.typo3.org/m/typo3/reference-coreapi/13.4/en-us/Administration/Installation/Index.html

Only if by going up no page is found, then the 404 is displayed. This way we can keep ppl in context

Calling a missing page directly then has the same effect like Using the version switch when the page does not exist anymore in the newer version.

For example if you switch from

https://docs.typo3.org/m/typo3/reference-tca/11.5/en-us/Columns/Properties/Description.html to main via the version switch you are redirected to https://docs.typo3.org/m/typo3/reference-tca/main/en-us/Columns/. While if you try to call https://docs.typo3.org/m/typo3/reference-tca/main/en-us/Columns/Properties/Description.html directly you get a 404 displayed which takes you completely out of the context of what manual and version you where in and even though the description you are seeking is still available.

This prevent showing the 403 Forbidden message and instead gives better results. It also prevents us from having to create orphan Index.rst files in folders that are directly integrated into menues and have no logical index.

https://docs.typo3.org/m/typo3/reference-coreapi/13.4/en-us/Administration/Installation/Environments/Index.html

Would redirect to 

https://docs.typo3.org/m/typo3/reference-coreapi/13.4/en-us/Administration/Installation/Index.html

Then
@NeoBlack
Copy link
Member

@andreaskienast let's talk about this patch after your vacation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants