[BUGFIX] #42: exception when editing a tag or author

[dmitryd]

Fixes #42 by removing wrong displayCond.

[benjaminkott]

@NeoBlack I need your opinion on this one. I could reproduce the issue if I add a storage folder outside the root and then add authors etc to it. Opening the record again will produce the error @dmitryd described. I am not sure if we should handle this at all, because I am unaware of possible side-effects, with duplicate slug entries for example.

This does not happen if you add categories to the root itself, but slug fields are not generated correctly.

[NeoBlack]

As described in the issue, the display condition is for pages only, so for me, it was a mistake to use this display condition for tags and categories.
I guess we should accept this PR and if other errors occur we have to think about a solution, e.g. with an own display condition class.

[benjaminkott]

@NeoBlack I´ve may found an issue in the PseudoSiteTcaDisplayCondition it fails for all not translatable records (without l10n_parent) that are out of a site. I´ve marked the point where it fails. https://github.com/TYPO3/TYPO3.CMS/blob/master/typo3/sysext/core/Classes/Compatibility/PseudoSiteTcaDisplayCondition.php#L61-L66

[dmitryd]

@benjaminkott

I am not sure if we should handle this at all, because I am unaware of possible side-effects, with duplicate slug entries for example.

You should because:

• displayCond is for pages only
• having a blog folder outside of the root is a use case for several sites sharing the same blog entries

[benjaminkott]

I´ve thought a lot about this issue, tested a lot and talked a lot about with different persons. Removing the condition seems to be the best option we have after all. It does not make it worse or solved the initial intend. But it´s at least avoiding the exception. We will reconsider it when we have a better solution.