[BUGFIX] Enforce ArchiveViewHelper to return a string #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the configuration `plugin.tx_blog.settings.archiveUid` is undefined, the link to the archive pages cannot be built which causes the "generation" of the link text only. However, this may fail if only the year is returned, as it is an integer. This patch adds a string cast to the rendering result to handle year-only results as strings as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the configuration
plugin.tx_blog.settings.archiveUidis undefined,the link to the archive pages cannot be built which causes the
"generation" of the link text only. However, this may fail if only the
year is returned, as it is an integer.
This patch adds a string cast to the rendering result to handle
year-only results as strings as well.