runTests.sh and nullable fix #609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implicit nullable method parameters are deprecated with PHP 8.4. The patch prepares affected method signatures and activates an according php-cs-fixer rule.
TYPO3 Core streamlined the `runTests.sh` script already to allow the usage of podman or docker as container execution binary, favourising the `podmand` due to several reasons. To make this possible `docker-compose` has been replaced with direct binary usage. To adopt these streamlining changes, this change * adopts podman/docker binary switch `-b`. * drops `docker-compose` usage in favour of using docker/podman calls directly. * drops `.env` file creation. * drops script debugging option `-v`. * adds PHP 8.3 as allowed php version. * adjusts the help text for implemented changes. * displays a hint for helptext on invalid option to avoid the missing due to the lengthy text output. * adds phpunit configuration for unit test with testing-framework paths to eliminate the need to specify the testing folder explicitly. Releases: main, 7, 6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.