[TASK] Do not hard require typo3/cms-install #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TF itself has no hard dependency to typo3/cms-install. > composer rem typo3/cms-install
sbuerk
approved these changes
Feb 26, 2024
|
Actually there currently is a hard dependency, at least on TYPO3v12: https://github.com/TYPO3/testing-framework/blob/8.1.0/Classes/Core/Testbase.php#L250 This currently lets functional tests fail: https://github.com/pagemachine/typo3-formlog/actions/runs/9609757403/job/26504856080
Also the check for So this should be reverted or further adjustments are necessary to make Of course, the workaround for now would be adding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TF itself has no hard dependency to typo3/cms-install.