[TASK] Avoid calling deprecated Platform->getName()
#522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The doctrine team deprecated the `getName()` method
for platform classes within `doctrine/dbal 3.x` [1].
This change modifes userland code to
a) replace `getName()` with `instanceof` checks
Using `instanceof` checks against the connection platform
is the propose replacement for the deprecated `getName()`
method.
b) Use prefixed class namespace alias for imported platforms
Instead of
use Doctrine\DBAL\Platforms\SqlitePlatform;
prefixed alias is used:
use Doctrine\DBAL\Platforms\SqlitePlatform
as DoctrineSQLitePlatform;
Only caveat is, that static code analysers like PHPStan
may report it.
[1] https://github.com/doctrine/dbal/blob/3.7.x/UPGRADE.md#deprecated-abstractplatformgetname
Releases: main
lolli42
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The doctrine team deprecated the
getName()methodfor platform classes within
doctrine/dbal 3.x[1].This change modifes userland code to
a) replace
getName()withinstanceofchecksUsing
instanceofchecks against the connection platformis the propose replacement for the deprecated
getName()method.
b) Use prefixed class namespace alias for imported platforms
Instead of
use Doctrine\DBAL\Platforms\SqlitePlatform;
prefixed alias is used:
use Doctrine\DBAL\Platforms\SqlitePlatform
as DoctrineSQLitePlatform;
Only caveat is, that static code analysers like PHPStan
may report it.
[1] https://github.com/doctrine/dbal/blob/3.7.x/UPGRADE.md#deprecated-abstractplatformgetname
Releases: main