Skip to content

Commit

Permalink
[TASK] Avoid no longer needed unset() in tearDown() (#565)
Browse files Browse the repository at this point in the history
Recent phpunit 10.5 and 11.2 versions improved internal
memory handling significantly. This obsoletes the
dedicated unset() calls we had in tearDown() of
functional test cases.
  • Loading branch information
lolli42 authored Jun 20, 2024
1 parent cebb265 commit ee9f3da
Showing 1 changed file with 0 additions and 9 deletions.
9 changes: 0 additions & 9 deletions Classes/Core/Functional/FunctionalTestCase.php
Original file line number Diff line number Diff line change
Expand Up @@ -406,15 +406,6 @@ protected function tearDown(): void
) {
@unlink($this->instancePath . '/typo3temp/var/cache/code/core/sites-configuration.php');
}

// Unset especially the container after each test, it is a huge memory hog.
// Test class instances in phpunit are kept until end of run, this sums up.
unset($this->container);
unset($this->identifier, $this->instancePath, $this->coreExtensionsToLoad);
unset($this->testExtensionsToLoad, $this->pathsToLinkInTestInstance);
unset($this->pathsToProvideInTestInstance, $this->configurationToUseInTestInstance);
unset($this->additionalFoldersToCreate);

parent::tearDown();
}

Expand Down

0 comments on commit ee9f3da

Please sign in to comment.