-
-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Add flag to site config to skip DataHandler hooks #4109
base: release-12.0.x
Are you sure you want to change the base?
Conversation
Thanks for that feature. Why not using the "Enable Solr for this site" checkbox from Site-Config? What happens with mounted pages between different sites? I'll change the base and target branch to release-12.0.x to be able to run the tests. Currently the main branch not stable enough for new features. We'll switch back to main, if that feature should be merged. |
@dkd-kaehm, to be honest I don't know the implications behind that Thing is, we are using EXT:solr for the site in question but not its indexing. That's why we needed a separate flag. Does this make sense? I not 100% sure ;-) I've noticed that RecordMonitor checks on |
OK, you see, there is another way with I would propose to fix the existing things if they not working well, instead of introducing new settings. |
Thanks for pointing that out! (didn't know about that). But unfortunately that's a global option, right? I need a per site option. Hence my PR. |
This could be a option for that feature. |
My first thought was also that it might be useful to be able to set the But if Solr connections are deactivated for a site, it makes sense to cancel the monitoring, but I'm not sure what effect this will have on mounted sites. I think there are some possible side effects to consider here. |
3cf43b6
to
8f60143
Compare
I've come across another problem now: trying to save |
Currently the 2 hooks of EXT:solr into DataHandler are fired for all sites, their pages and records. This is time consuming. Especially the RecordMonitor is taking up to 10s to do its thing. Both GarbageCollector and RecordMonitor should skip their processDatamap_afterDatabaseOperations method, to avoid unneccessery processing for sites. Fixes: TYPO3-Solr#4108
5c6ad77
to
f6faa27
Compare
What this pr does
Currently the 2 hooks of EXT:solr into DataHandler are fired for all sites, their pages and records. This is time consuming. Especially the RecordMonitor is taking up to 10s to do its thing.
How to test
Add the flag
solr_skip_hooks
to a site config file and edit/save one of it's pages. Both GarbageCollector and RecordMonitor should skip theirprocessDatamap_afterDatabaseOperations
method.Fixes: #4108
Maintainers Notes: