Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Add init command to setup documentation #850

Merged
merged 12 commits into from
Dec 16, 2024
Merged

Conversation

jaapio
Copy link
Contributor

@jaapio jaapio commented Nov 26, 2024

First version of an init command that will setup the Documentation directory. This includes a very basic guides.xml. Therefor the user has to answer a number of questions that will fill in the defaults.

Copy link
Contributor

@garvinhicking garvinhicking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, thanks, I didn't know you were working on this. That's great! :-)

Few suggestions and questions.

packages/typo3-guides-cli/src/Command/InitCommand.php Outdated Show resolved Hide resolved
packages/typo3-guides-cli/src/Command/InitCommand.php Outdated Show resolved Hide resolved
packages/typo3-guides-cli/src/Command/InitCommand.php Outdated Show resolved Hide resolved
packages/typo3-guides-cli/src/Command/InitCommand.php Outdated Show resolved Hide resolved
packages/typo3-guides-cli/src/Command/InitCommand.php Outdated Show resolved Hide resolved
packages/typo3-guides-cli/src/Command/InitCommand.php Outdated Show resolved Hide resolved
packages/typo3-guides-cli/src/Command/InitCommand.php Outdated Show resolved Hide resolved
jaapio and others added 2 commits December 15, 2024 07:45
First version of an init command that will setup the Documentation directory.
This includes a very basic guides.xml. Therefor the user has to answer a
number of questions that will fill in the defaults.
@linawolf linawolf force-pushed the feature/init-command branch from 41db960 to 3b0cb2e Compare December 15, 2024 06:46
Release is actually not used anywhere, version is only used during local rendering, both tend to confuse users.
That package is required by all other packages and Packagist is a related topic
@linawolf linawolf force-pushed the feature/init-command branch from 1c9be29 to 31e3b34 Compare December 15, 2024 08:53
@linawolf
Copy link
Member

@jaapio how can I try this out?

jaapio and others added 2 commits December 15, 2024 11:55
We need to disable deprecations as those are breaking the auto completion in the
cli commands.
@linawolf linawolf force-pushed the feature/init-command branch from bd7bbb2 to d0abe33 Compare December 16, 2024 10:07
@linawolf linawolf requested a review from sfroemkenjw December 16, 2024 10:30
@linawolf linawolf force-pushed the feature/init-command branch from 4ca8af0 to ae4ff0c Compare December 16, 2024 10:55
Copy link
Contributor

@sfroemkenjw sfroemkenjw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not tested in reallife, but look good to me, except all the duplicate empty lines.

@linawolf linawolf merged commit 01ef2cf into main Dec 16, 2024
8 checks passed
@linawolf linawolf deleted the feature/init-command branch December 16, 2024 18:07
@garvinhicking
Copy link
Contributor

Post +1 on this, thank you! :-*

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants