[BUGFIX] Fix siteLanguage("locale") TypoScript condition example
#1436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current example for the `siteLanguage` condition does not seem to be working. If I understand the code correctly, the locale string will be normalized to use dashes (e.g. `fr-CH`) as separator instead of an underscore (`fr_CH`) (see [Locale.php](https://git.typo3.org/typo3/typo3/-/blob/22b303f63282e422533b37b09c624900c5995c70/typo3/sysext/core/Classes/Localization/Locale.php#L104). The output of "locale" in `<f:debug>{siteLanguage}</f:debug>` is also a bit misleading as it uses the `posixFormatted` version instead of the one used in the TypoScript condition. Please check this proposed change carefully, as I may not understand the whole picture and/or some things depend on the actual hosting environment.
|
Attention! A preport to main is probably needed |
|
Should I close this PR and create on against |
|
If it is not to much work that would be great. Our automatic backport workflow only works for PRs against main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current example for the
siteLanguagecondition does not seem to be working. If I understand the code correctly, the locale string will be normalized to use dashes (e.g.fr-CH) as separator instead of an underscore (fr_CH) (see Locale.php.The output of "locale" in
<f:debug>{siteLanguage}</f:debug>is also a bit misleading as it uses theposixFormattedversion instead of the one used in the TypoScript condition.Please check this proposed change carefully, as I may not understand the whole picture and/or some things depend on the actual hosting environment.