Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Overhaul PAGE chapter #1166

Merged
merged 2 commits into from
Apr 3, 2024
Merged

[TASK] Overhaul PAGE chapter #1166

merged 2 commits into from
Apr 3, 2024

Conversation

linawolf
Copy link
Member

@linawolf linawolf commented Apr 2, 2024

  • Use confvals instead of tables
  • Correct indentation
  • Give headlines to examples
  • Introduce a toc for the properties

* Use confvals instead of tables
* Correct indentation
* Give headlines to examples
* Introduce a toc for the properties
Documentation/Setup/Page/Index.rst Outdated Show resolved Hide resolved
Documentation/Setup/Page/Index.rst Outdated Show resolved Hide resolved
Documentation/Setup/Page/Index.rst Outdated Show resolved Hide resolved
@linawolf linawolf requested a review from brotkrueml April 3, 2024 16:31
@linawolf linawolf merged commit a7414bb into main Apr 3, 2024
2 checks passed
@linawolf linawolf deleted the task/aspect branch April 3, 2024 16:56
Copy link
Contributor

github-actions bot commented Apr 3, 2024

The backport to 11.5 failed:

The process '/usr/bin/git' failed with exit code 1
stderr
error: could not apply 50dbaabe... [TASK] Overhaul PAGE chapter
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

stdout
Auto-merging Documentation/Setup/Page/Index.rst
CONFLICT (content): Merge conflict in Documentation/Setup/Page/Index.rst

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-11.5 11.5
# Navigate to the new working tree
cd .worktrees/backport-11.5
# Create a new branch
git switch --create backport-1166-to-11.5
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick 50dbaabe64c28ef23d9165b8854c3d8414079d68,d7959c53fe9b583dd98b036d67b8b896407e7abb
# Push it to GitHub
git push --set-upstream origin backport-1166-to-11.5
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-11.5

Then, create a pull request where the base branch is 11.5 and the compare/head branch is backport-1166-to-11.5.

@linawolf linawolf added backport-done Changes have been backported to other branches already and removed backport failed labels Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 12.4 backport-done Changes have been backported to other branches already
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants