Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Feature: #97187 - PSR-14 Event for modifying link explanation #1794

Merged
merged 2 commits into from
Apr 6, 2022

Conversation

@linawolf linawolf requested a review from susannemoog April 5, 2022 16:14
@alexander-nitsche alexander-nitsche self-requested a review April 6, 2022 12:02
Copy link
Contributor

@alexander-nitsche alexander-nitsche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR #1795 uses

:caption: EXT:my_extension/..

instead of

:caption: my_extension/

which should be used here too, from my point of view.

@linawolf
Copy link
Member Author

linawolf commented Apr 6, 2022

I changed it. Feel free to make such minor changes directly.

@linawolf linawolf enabled auto-merge (squash) April 6, 2022 12:19
@linawolf linawolf merged commit 06dd8a3 into main Apr 6, 2022
@linawolf linawolf deleted the feature-ModifyLinkExplanationEvent branch April 6, 2022 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants