Skip to content

Commit

Permalink
Work around google/guava#7397
Browse files Browse the repository at this point in the history
which results in

> Task :android:app:full:minifyReleaseWithR8
ERROR: Missing classes detected while running R8. Please add the missing classes or apply additional keep rules that are generated in /home/runner/work/net.twisterrob.travel/net.twisterrob.travel/android/app/full/build/outputs/mapping/release/missing_rules.txt.
ERROR: R8: Missing class com.google.j2objc.annotations.ReflectionSupport (referenced from: com.google.common.util.concurrent.AbstractFuture)
Missing class com.google.j2objc.annotations.RetainedWith (referenced from: com.google.common.collect.ImmutableSet com.google.common.collect.ImmutableMap.entrySet and 3 other contexts)

because places 4.1.0 added guava 33.3.0 dep
  • Loading branch information
TWiStErRob committed Dec 10, 2024
1 parent 82abe3f commit ad6d191
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
2 changes: 2 additions & 0 deletions android/feature/range/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -20,5 +20,7 @@ dependencies {
implementation(projects.common.model)
implementation(projects.common.feed.core)
implementation(libs.gms.places)
// TODO remove this when places has a transitive dependency 33.3.0+
implementation(libs.google.guava.android)
implementation(libs.jsr305)
}
2 changes: 2 additions & 0 deletions gradle/libs.versions.toml
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ google-appengine = "2.0.31"
google-appengine-plugin = "2.8.1"
google-maps = "19.0.0"
google-places = "4.1.0"
google-guava-android = "33.3.1-android"

micronaut = "4.7.1"
micronaut-gradle = "4.4.4"
Expand Down Expand Up @@ -87,6 +88,7 @@ google-cloud-secrets = { module = "com.google.cloud:google-cloud-secretmanager"
appengine-api = { module = "com.google.appengine:appengine-api-1.0-sdk", version.ref = "google-appengine" }
gms-places = { module = "com.google.android.libraries.places:places", version.ref = "google-places" }
gms-maps = { module = "com.google.android.gms:play-services-maps", version.ref = "google-maps" }
google-guava-android = { module = "com.google.guava:guava", version.ref = "google-guava-android" }

test-junit4 = { module = "junit:junit", version.ref = "junit4" }
test-junit5 = { module = "org.junit.jupiter:junit-jupiter", version.ref = "junit5" }
Expand Down

0 comments on commit ad6d191

Please sign in to comment.