Skip to content

Commit

Permalink
Mark all suppressions with TODO
Browse files Browse the repository at this point in the history
  • Loading branch information
TWiStErRob committed Dec 3, 2023
1 parent 7c8f413 commit 9b74ae5
Show file tree
Hide file tree
Showing 8 changed files with 18 additions and 18 deletions.
4 changes: 2 additions & 2 deletions Android/src/main/java/net/twisterrob/blt/android/App.java
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ public App() {

@Override protected Object createDatabase() {
DataBaseHelper db = new DataBaseHelper(this);
@SuppressWarnings({"unused", "deprecation"}) // https://github.com/TWiStErRob/net.twisterrob.travel/issues/15
@SuppressWarnings({"unused", "deprecation"}) // TODO https://github.com/TWiStErRob/net.twisterrob.travel/issues/15
Object task = new BackgroundExecution(new Runnable() {
@Override public void run() {
db().openDB();
Expand All @@ -78,7 +78,7 @@ public AndroidStaticData getStaticData() {
}

public static void sendMail(String body) {
@SuppressWarnings({"unused", "deprecation"}) // https://github.com/TWiStErRob/net.twisterrob.travel/issues/15
@SuppressWarnings({"unused", "deprecation"}) // TODO https://github.com/TWiStErRob/net.twisterrob.travel/issues/15
Object task = new MailSenderAsyncTask("Better London Travel",
"[email protected]", "[email protected]") {
@Override protected void onPostExecute(Boolean result) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -144,8 +144,8 @@ private void startLoadingData() {
private void delayedGetRoot() {
Map<String, Object> args = new HashMap<>();
args.put("line", m_line);
@SuppressLint("StaticFieldLeak") // https://github.com/TWiStErRob/net.twisterrob.travel/issues/15
@SuppressWarnings({"unused", "deprecation"}) // https://github.com/TWiStErRob/net.twisterrob.travel/issues/15
@SuppressLint("StaticFieldLeak") // TODO https://github.com/TWiStErRob/net.twisterrob.travel/issues/15
@SuppressWarnings({"unused", "deprecation"}) // TODO https://github.com/TWiStErRob/net.twisterrob.travel/issues/15
Object task = new DownloadFeedTask<PredictionSummaryFeed>(args) {
@Override protected void onPostExecute(AsyncTaskResult<Feed, PredictionSummaryFeed> result) {
if (result.getError() != null) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -113,8 +113,8 @@ public class RangeMapActivity extends MapActivity {
setupSearch(fm.findFragmentById(R.id.view__range__search));

updateToolbarVisibility();
@SuppressLint("StaticFieldLeak") // https://github.com/TWiStErRob/net.twisterrob.travel/issues/15
@SuppressWarnings({"unused", "deprecation"}) // https://github.com/TWiStErRob/net.twisterrob.travel/issues/15
@SuppressLint("StaticFieldLeak") // TODO https://github.com/TWiStErRob/net.twisterrob.travel/issues/15
@SuppressWarnings({"unused", "deprecation"}) // TODO https://github.com/TWiStErRob/net.twisterrob.travel/issues/15
Object task = new AsyncTask<Void, Void, Set<NetworkNode>>() {
@Override protected Set<NetworkNode> doInBackground(Void... params) {
return App.db().getTubeNetwork();
Expand Down Expand Up @@ -400,8 +400,8 @@ private void addMarkers(Iterable<NetworkNode> nodes) {
}
}

@SuppressLint("StaticFieldLeak") // https://github.com/TWiStErRob/net.twisterrob.travel/issues/15
@SuppressWarnings({"unused", "deprecation"}) // https://github.com/TWiStErRob/net.twisterrob.travel/issues/15
@SuppressLint("StaticFieldLeak") // TODO https://github.com/TWiStErRob/net.twisterrob.travel/issues/15
@SuppressWarnings({"unused", "deprecation"}) // TODO https://github.com/TWiStErRob/net.twisterrob.travel/issues/15
private final class DrawAsyncTask extends SimpleAsyncTask<LatLng, DrawAsyncTask.Result, DrawAsyncTask.Result> {
private final Set<NetworkNode> nodes;
private final RangeMapGeneratorConfig config;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ private Collection<StationWithDistance> toStations(Collection<NetworkNode> nodes
return result;
}

@SuppressLint("StaticFieldLeak") // https://github.com/TWiStErRob/net.twisterrob.travel/issues/15
@SuppressLint("StaticFieldLeak") // TODO https://github.com/TWiStErRob/net.twisterrob.travel/issues/15
private final class GeocoderTask extends SimpleSafeAsyncTask<LatLng, Void, Address> {
private final Geocoder geocoder;
private GeocoderTask(Context context) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -98,8 +98,8 @@ private void delayedGetRoot() {
Map<String, Object> args = new HashMap<>();
args.put("line", line);
args.put("station", m_station.getTrackerNetCode(line));
@SuppressLint("StaticFieldLeak") // https://github.com/TWiStErRob/net.twisterrob.travel/issues/15
@SuppressWarnings({"unused", "deprecation"}) // https://github.com/TWiStErRob/net.twisterrob.travel/issues/15
@SuppressLint("StaticFieldLeak") // TODO https://github.com/TWiStErRob/net.twisterrob.travel/issues/15
@SuppressWarnings({"unused", "deprecation"}) // TODO https://github.com/TWiStErRob/net.twisterrob.travel/issues/15
Object task = new DownloadFeedTask<PredictionSummaryFeed>(args) {
@Override protected void onPostExecute(AsyncTaskResult<Feed, PredictionSummaryFeed> result) {
if (result.getError() != null) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,8 @@ public void onItemClick(AdapterView<?> parent, View view, int position, long id)
}
});

@SuppressLint("StaticFieldLeak") // https://github.com/TWiStErRob/net.twisterrob.travel/issues/15
@SuppressWarnings({"unused", "deprecation"}) // https://github.com/TWiStErRob/net.twisterrob.travel/issues/15
@SuppressLint("StaticFieldLeak") // TODO https://github.com/TWiStErRob/net.twisterrob.travel/issues/15
@SuppressWarnings({"unused", "deprecation"}) // TODO https://github.com/TWiStErRob/net.twisterrob.travel/issues/15
Object task = new AsyncTask<Void, Void, List<Station>>() {
@Override protected List<Station> doInBackground(Void... params) {
return App.db().getStations();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,8 @@ private void startLoadingData() {
}

private void delayedGetRoot() {
@SuppressLint("StaticFieldLeak") // https://github.com/TWiStErRob/net.twisterrob.travel/issues/15
@SuppressWarnings({"unused", "deprecation"}) // https://github.com/TWiStErRob/net.twisterrob.travel/issues/15
@SuppressLint("StaticFieldLeak") // TODO https://github.com/TWiStErRob/net.twisterrob.travel/issues/15
@SuppressWarnings({"unused", "deprecation"}) // TODO https://github.com/TWiStErRob/net.twisterrob.travel/issues/15
Object task = new DownloadFeedTask<LineStatusFeed>() {
@Override protected void onPostExecute(AsyncTaskResult<Feed, LineStatusFeed> result) {
if (result.getError() != null) {
Expand Down
6 changes: 3 additions & 3 deletions gradle/libs.versions.toml
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,15 @@ java = "1.8"
java-android = "17"
java-appengine = "17"

#noinspection AndroidGradlePluginVersion https://github.com/TWiStErRob/net.twisterrob.travel/issues/13
#noinspection AndroidGradlePluginVersion TODO https://github.com/TWiStErRob/net.twisterrob.travel/issues/13
agp = "8.1.1"
twisterrob = "0.16"
gretty = "4.1.1"

jsr305 = "3.0.2"
kxml2 = "2.3.0"
sqlite-jdbc = "3.44.1.0"
#noinspection GradleDependency https://github.com/TWiStErRob/net.twisterrob.travel/issues/11
#noinspection GradleDependency TODO https://github.com/TWiStErRob/net.twisterrob.travel/issues/11
glide = "3.8.0"

slf4j = "2.0.9"
Expand All @@ -28,7 +28,7 @@ google-appengine = "2.0.22"
google-appengine-plugin = "2.5.0"
# TODO replace SupportPlaceAutocompleteFragment when updating to AndroidX
# TODO update to 17.0.0 when using AndroidX
#noinspection GradleDependency,OutdatedLibrary https://github.com/TWiStErRob/net.twisterrob.travel/issues/12
#noinspection GradleDependency,OutdatedLibrary TODO https://github.com/TWiStErRob/net.twisterrob.travel/issues/12
google-maps = "16.1.0"
google-datastore = "2.17.6"

Expand Down

0 comments on commit 9b74ae5

Please sign in to comment.