Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[autoscraping-4] Agressive guessing for roomfinder rooms #463

Merged
merged 4 commits into from
Mar 25, 2023
Merged

[autoscraping-4] Agressive guessing for roomfinder rooms #463

merged 4 commits into from
Mar 25, 2023

Conversation

CommanderStorm
Copy link
Member

image

Proposed Changes (include Screenshots if possible)

  • Added a guess pass with two letters
    image

How to test this PR

  1. Code Review

How has this been tested?

  • Look at what does cause the different result

Checklist:

  • I have updated the documentation / No need to update the documentation
  • I have run the linter

@CommanderStorm CommanderStorm added the data This issue is related to the data collection and aggregation label Mar 21, 2023
@CommanderStorm CommanderStorm requested a review from octycs March 21, 2023 01:01
@CommanderStorm CommanderStorm self-assigned this Mar 21, 2023
@github-actions
Copy link
Contributor

👋 Thank you for contributing. A staging environment for this PR for this change will be available shortly

github-actions bot added a commit that referenced this pull request Mar 21, 2023
@github-actions
Add deployment for PR #463
a086d8c
@CommanderStorm CommanderStorm changed the base branch from main to decorator_scraper March 21, 2023 01:22
@CommanderStorm CommanderStorm changed the base branch from decorator_scraper to logging_for_roomfinder.scrape_rooms March 21, 2023 01:22
octycs
octycs approved these changes Mar 21, 2023
View reviewed changes
Copy link
Contributor

@octycs octycs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be curious what this one single room was, that we always missed :D

@CommanderStorm CommanderStorm force-pushed the logging_for_roomfinder.scrape_rooms branch from 803e59c to 0de4c55 Compare March 21, 2023 13:00
@CommanderStorm CommanderStorm force-pushed the logging_for_roomfinder.scrape_rooms branch from 0de4c55 to 7127d47 Compare March 21, 2023 13:12
Base automatically changed from logging_for_roomfinder.scrape_rooms to main March 21, 2023 13:13
@CommanderStorm
Copy link
Member Author

I'd be curious what this one single room was, that we always missed :D

Can be arranged: I am rebasing some things and will add a scraping run for this PR

@CommanderStorm CommanderStorm changed the title [autoscraping-3] Agressive guessing for roomfinder rooms [autoscraping-4] Agressive guessing for roomfinder rooms Mar 21, 2023
@CommanderStorm CommanderStorm changed the base branch from main to data_update March 21, 2023 13:24
@CommanderStorm CommanderStorm requested a review from octycs March 21, 2023 14:10
@CommanderStorm
Copy link
Member Author

@octycs I have added the missing room

Base automatically changed from data_update to main March 25, 2023 19:04
@CommanderStorm CommanderStorm merged commit 4e00f08 into main Mar 25, 2023
@CommanderStorm CommanderStorm deleted the agressive_guessing branch March 25, 2023 19:05
github-actions bot added a commit that referenced this pull request Mar 25, 2023
@github-actions
Removed the deployment for PR #463
dd5b608
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@octycs octycs octycs approved these changes

Assignees

@CommanderStorm CommanderStorm

Labels
data This issue is related to the data collection and aggregation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CommanderStorm @octycs