Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(guides): Move AV1 to unwanted #1968

Merged
merged 6 commits into from
Jun 9, 2024
Merged

Conversation

yammes08
Copy link
Contributor

@yammes08 yammes08 commented Jun 9, 2024

Pull Request

Purpose

Resolve: #1962

Approach

  • Remove AV1 from Radarr and Sonarr optional guide sections.
  • Add AV1 to Radarr and Sonarr unwanted guide sections.
  • Add AV1 to Radarr and Sonarr profile JSON files.
  • Built and tested locally.

Open Questions and Pre-Merge TODOs

None

Requirements

@yammes08 yammes08 changed the title Feat(guides): Move AV1 to unwanted feat(guides): Move AV1 to unwanted Jun 9, 2024
@github-actions github-actions bot added the Area: Backend Backend Changes, not related to a specific section label Jun 9, 2024
Copy link
Contributor

github-actions bot commented Jun 9, 2024

@yammes08 your pull request title "Feat(guides): Move AV1 to unwanted" does not conform to our naming conventions.

Please update the title to match the pattern: "feat|build|chore|style|fix|update|ci(<area>): <description>

You can check your title at this regex101 link."

@yammes08 yammes08 requested a review from a team June 9, 2024 12:27
@yammes08 yammes08 self-assigned this Jun 9, 2024
@yammes08 yammes08 added Status: Confirmed The issue has been confirmed Type: Enhancement Feature Request or Improvement of suboptimal status quo Status: Review Needed Ready for Review Area: Sonarr Sonarr Related Area: Radarr Radarr Related Type: Guide Request Requested new guide or enhancements to guide labels Jun 9, 2024
@yammes08
Copy link
Contributor Author

yammes08 commented Jun 9, 2024

@yammes08 your pull request title "Feat(guides): Move AV1 to unwanted" does not conform to our naming conventions.

Please update the title to match the pattern: "feat|build|chore|style|fix|update|ci():

You can check your title at this regex101 link."

Updated

@yammes08
Copy link
Contributor Author

yammes08 commented Jun 9, 2024

I also added .DS_Store to .gitignore.

TRaSH-
TRaSH- previously approved these changes Jun 9, 2024
Copy link
Contributor

@TRaSH- TRaSH- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it locally on the different quality profiles and i didn't see any issues

@yammes08
Copy link
Contributor Author

yammes08 commented Jun 9, 2024

Tested it locally on the different quality profiles and i didn't see any issues

I need to update the Collection tables before merging.

Copy link
Contributor

@mvanbaak mvanbaak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yammes08 yammes08 removed the request for review from TRaSH- June 9, 2024 16:28
Copy link
Contributor

@TRaSH- TRaSH- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved after a minor change

@TRaSH- TRaSH- merged commit e6192e1 into master Jun 9, 2024
9 checks passed
@TRaSH- TRaSH- deleted the feat(Guides)/move-av1-to-unwanted branch June 9, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Backend Backend Changes, not related to a specific section Area: Radarr Radarr Related Area: Sonarr Sonarr Related Status: Confirmed The issue has been confirmed Status: Review Needed Ready for Review Type: Enhancement Feature Request or Improvement of suboptimal status quo Type: Guide Request Requested new guide or enhancements to guide
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request] (Guide): move AV-1 from Optional to Unwanted
3 participants