Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(guide): Update Clean.py for py3.12 and apply updates #1953

Merged
merged 1 commit into from
May 30, 2024

Conversation

thezoggy
Copy link
Contributor

@thezoggy thezoggy commented May 30, 2024

Pull Request

Purpose

Fixes SyntaxWarning thrown by python 3.12, update sync up nzbget from updates from sab version

Approach

Script now generates SyntaxWarning on python 3.12+

python3.12 changes:

A backslash-character pair that is not a valid escape sequence now generates a SyntaxWarning, instead of DeprecationWarning. For example, re.compile("\d+\.\d+") now emits a SyntaxWarning ("\d" is an invalid escape sequence, use raw strings for regular expression: re.compile(r"\d+\.\d+")). In a future Python version, SyntaxError will eventually be raised, instead of SyntaxWarning. (Contributed by Victor Stinner in gh-98401.)

Open Questions and Pre-Merge TODOs

  • Tested on SABnzbd with python 3.12 and python < 3.12
  • Tested on NZBget with python 3.12 and python < 3.12

Requirements

@github-actions github-actions bot added Area: Python Pull requests that update Python code Area: Backend Backend Changes, not related to a specific section Area: Downloaders Downloaders Related labels May 30, 2024
@zakkarry zakkarry merged commit f8d8b8e into TRaSH-Guides:master May 30, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Backend Backend Changes, not related to a specific section Area: Downloaders Downloaders Related Area: Python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants