Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced spring support. #94

Merged
merged 2 commits into from
Aug 1, 2015
Merged

Enhanced spring support. #94

merged 2 commits into from
Aug 1, 2015

Conversation

TripleNail
Copy link
Contributor

Spring beans that are used as stages/step can now be fully managed by spring.

I also added a new JGivenStage annotation so that writing spring based JGiven stages is very simple. Just setup spring for JGiven usage as shown in the examples and annotate your stages with JGivenStage

@janschaefer
Copy link
Contributor

Very cool! Thanks a lot for that. The Spring support was very rudimentary so far ;-)

@CrystalMethod
Copy link

👍

@janschaefer janschaefer added this to the v0.8.0 milestone Jul 31, 2015
* applied suggested refactorings
* fixed clumsy javadoc
@Retention(RetentionPolicy.RUNTIME)
@Documented
@Component
public @interface JGivenStage {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this maybe also be @Inherited?

@JGivenStage is meant as replacment for @Component which also does not use @Inherited

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok.

@TripleNail
Copy link
Contributor Author

Does this mean that users have to configure this themselves?

Currently yes, but maybe I will add some kind of auto-configuration facility like @EnableJGivenSupport (and equivalent xml-based method as well) in 0.8.1

janschaefer added a commit that referenced this pull request Aug 1, 2015
@janschaefer janschaefer merged commit 4ab9fd0 into TNG:master Aug 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants