HTML5 report: fix issue with duplicate values in table paramaters (fixes

#89)
TNG · Jul 14, 2015 · fcd151b · fcd151b
1 parent ed89d29
commit fcd151b
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 18 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,11 +2,7 @@
 
 ## Fixed Issues
 
-* Fixed an issue that the `@Description` annotation was not regarded for methods with the `@IntroWord` [#87](https://github.com/TNG/JGiven/issues/87)
-
-## New Annotation
-
-* Introduced the `@As` annotation that replaces the `@Description` annotation when used on step methods and test methods. The `@Description` annotation should only be used for descriptions of test classes.
+* HTML5 Report: tables with duplicate entries cannot be used as step parameters [#89](https://github.com/TNG/JGiven/issues/89)
 
 # v0.7.3
 
@@ -96,6 +92,16 @@ In previous versions of JGiven you would have to add an `and()` before `a_banana
 
 #### Example
 
+##### POJO
+```
+class CoffeeWithPrice {
+    String name;
+    double price_in_EUR;
+    CoffeeWithPrice(String name, double priceInEur) {
+        this.name = name;
+        this.price_in_EUR = priceInEur;
+    }
+
 ##### POJO
 ```
 class CoffeeWithPrice {
@@ -264,16 +270,6 @@ To help the reader, the differences are now highlighted in the HTML report.
 * Elapsed time in HTML report should be shown in a convenient unit [#24](https://github.com/TNG/JGiven/issues/24)
 * Test against different JUnit versions [#22](https://github.com/TNG/JGiven/issues/22)
 
-## Fixed Bugs
-
-* JGiven creates null.json files for test classes where all tests are ignored [#25](https://github.com/TNG/JGiven/issues/25)
-* Printed reports should not have collapsed scenarios [#23](https://github.com/TNG/JGiven/issues/23)
-
-## Backwards incompatible changes
-
-### JSON Model
-
-* The JSON model has been changed to support [#15](https://github.com/TNG/JGiven/issues/15).
   This means that JSON models generated with v0.4.0 will not work with the report generator of v0.5.0.
   This is in general no problem, because new JSON files are generated each time you execute your tests.
 

diff --git a/jgiven-html5-report/src/app/index.html b/jgiven-html5-report/src/app/index.html
@@ -48,7 +48,7 @@ <h1><a href="#/">JGiven Report</a></h1>
 
           <nav class="breadcrumbs">
             <a ng-hide="currentPage.breadcrumbs" href="#" class="current">/</a>
-            <a ng-cloak ng-repeat="b in currentPage.breadcrumbs" href="#" class="{{$last ? 'current' : 'unavailable'}}">{{b}}</a>
+            <a ng-cloak ng-repeat="b in currentPage.breadcrumbs track by $index" href="#" class="{{$last ? 'current' : 'unavailable'}}">{{b}}</a>
           </nav>
 
         </div>
@@ -325,7 +325,7 @@ <h5 class="toggle" ng-click="case.expanded = !case.expanded" ng-if="scenario.sce
                                   <table class="table-value" ng-if="word.argumentInfo.dataTable">
                                     <tr ng-repeat="row in word.argumentInfo.dataTable.data">
                                       <td class="{{ isHeaderCell($parent.$index, $index, word.argumentInfo.dataTable.headerType) ? 'header-cell' : '' }}"
-                                          ng-repeat="value in row">{{ value }}</td>
+                                          ng-repeat="value in row track by $index">{{ value }}</td>
                                     </tr>
                                   </table>
                                 </span>
@@ -363,7 +363,7 @@ <h6>Cases</h6>
                             <table>
                               <tr>
                                 <th>#</th>
-                                <th ng-repeat="param in scenario.derivedParameters">{{param}}</th>
+                                <th ng-repeat="param in scenario.derivedParameters track by $index">{{param}}</th>
                                 <th>Status</th>
                               </tr>
                               <tr ng-repeat="case in scenario.scenarioCases">