-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
General rule to test that class and its test are both at the same package #475
Comments
You can define a custom |
Yes, I can. But I think that it's a useful common and reusable feature to add it to the library. It's more fundamental than restrictions for joda-time or JUL |
I agree, even though I wonder if the naming pattern should be customizable 🤔 |
Hi, @codecholeric! Could you please assign this to me? I would like to try help with this issue :) Thanks! |
@Rossalli are you still working on that one? can I pick this up? |
Hi @mslowiak, I'm working on that :) |
@Rossalli how is your progress? |
Since the last comment from @Rossalli is from almost a year ago and there has been no reply to the last ping for over a month I would consider this issue open for grabs again... |
@codecholeric So, can I pick this up? :) |
Yes, feel free to pick it up! (Sorry if you're really still working on it @Rossalli, but without any life sign for so long I can't block the issue forever) |
@mslowiak I assigned you to it for transparency, hope that's okay 😉 |
… the same package as implementation class
…in the same package as implementation class
…in the same package as implementation class Signed-off-by: Marcin Słowiak <[email protected]>
…in the same package as implementation class Signed-off-by: Marcin Słowiak <[email protected]>
This will add the library rule `GeneralCodingRules.testClassesShouldResideInTheSamePackageAsImplementation(..)` which will test that implementation and test class reside in the same package. The rule can e.g. detect mismatches like `com.myapp.correct.SomeClass` and `com.myapp.wrong.SomeClassTest`. Resolves: #475
It will be convenient to have
GeneralCodingRules.TEST_SHOULD_HAVE_SAME_PACKAGE
rule to test that classesXxx
from/src/
andXxxTest
from/test/
are both at the same packageThe text was updated successfully, but these errors were encountered: