add toString to (Raw)InstanceofCheck

While `toString()` is not really intended as API we should always make sure there is some reasonable string output for debugging purposes. Signed-off-by: Peter Gafert <[email protected]>
TNG · Jan 30, 2021 · 5dcccc7 · 5dcccc7
1 parent 11006ed
commit 5dcccc7
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 3 deletions.
diff --git a/archunit/src/main/java/com/tngtech/archunit/core/domain/InstanceofCheck.java b/archunit/src/main/java/com/tngtech/archunit/core/domain/InstanceofCheck.java
@@ -19,6 +19,7 @@
 import com.tngtech.archunit.core.domain.properties.HasOwner;
 import com.tngtech.archunit.core.domain.properties.HasType;
 
+import static com.google.common.base.MoreObjects.toStringHelper;
 import static com.google.common.base.Preconditions.checkNotNull;
 import static com.tngtech.archunit.PublicAPI.Usage.ACCESS;
 
@@ -57,6 +58,15 @@ public int getLineNumber() {
         return lineNumber;
     }
 
+    @Override
+    public String toString() {
+        return toStringHelper(this)
+                .add("owner", owner)
+                .add("target", target)
+                .add("lineNumber", lineNumber)
+                .toString();
+    }
+
     static InstanceofCheck from(JavaCodeUnit owner, JavaClass target, int lineNumber) {
         return new InstanceofCheck(owner, target, lineNumber);
     }

diff --git a/archunit/src/main/java/com/tngtech/archunit/core/importer/RawInstanceofCheck.java b/archunit/src/main/java/com/tngtech/archunit/core/importer/RawInstanceofCheck.java
@@ -17,6 +17,7 @@
 
 import com.tngtech.archunit.core.domain.JavaClassDescriptor;
 
+import static com.google.common.base.MoreObjects.toStringHelper;
 import static com.google.common.base.Preconditions.checkNotNull;
 
 class RawInstanceofCheck {
@@ -28,15 +29,23 @@ private RawInstanceofCheck(JavaClassDescriptor target, int lineNumber) {
         this.lineNumber = lineNumber;
     }
 
-    public static RawInstanceofCheck from(JavaClassDescriptor target, int lineNumber) {
+    static RawInstanceofCheck from(JavaClassDescriptor target, int lineNumber) {
         return new RawInstanceofCheck(target, lineNumber);
     }
 
-    public JavaClassDescriptor getTarget() {
+    JavaClassDescriptor getTarget() {
         return target;
     }
 
-    public int getLineNumber() {
+    int getLineNumber() {
         return lineNumber;
     }
+
+    @Override
+    public String toString() {
+        return toStringHelper(this)
+                .add("target", target)
+                .add("lineNumber", lineNumber)
+                .toString();
+    }
 }