Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JOSS Feedback - Managing experiments #18

Merged
merged 3 commits into from
Mar 6, 2023
Merged

JOSS Feedback - Managing experiments #18

merged 3 commits into from
Mar 6, 2023

Conversation

a9p
Copy link
Member

@a9p a9p commented Mar 6, 2023

Suggest note about managing experiments as a solution to requested feature in #6.

@a9p a9p requested a review from arsedler9 March 6, 2023 07:24
@a9p a9p self-assigned this Mar 6, 2023
@a9p
Copy link
Member Author

a9p commented Mar 6, 2023

@arsedler9 Thoughts here? Do you think this needs to be further expanded?

arsedler9
arsedler9 approved these changes Mar 6, 2023
View reviewed changes
Copy link
Collaborator

@arsedler9 arsedler9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, I added a bit more detail but I think this should be sufficient!

@a9p
Copy link
Member Author

a9p commented Mar 6, 2023

Thanks! And I added in the docker notes per our earlier discussion.

@a9p a9p merged commit 8966c84 into master Mar 6, 2023
@a9p a9p deleted the a9p/docs/issue-6 branch March 6, 2023 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arsedler9 arsedler9 arsedler9 approved these changes

Assignees

@a9p a9p

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@a9p @arsedler9