Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TGM notices appear twice on theme options pages #237

Closed
manake opened this issue Nov 16, 2014 · 1 comment
Closed

TGM notices appear twice on theme options pages #237

manake opened this issue Nov 16, 2014 · 1 comment
Labels
Type: Bug

Comments

@manake
Copy link

manake commented Nov 16, 2014 •
edited
Loading

(Post removed. Fixed.)
@jrfnl
Copy link
Contributor

jrfnl commented Jan 13, 2015

I've send in PR #249 to fix this, please give it a +1 if you're happy with it.

@jrfnl jrfnl mentioned this issue Jan 13, 2015
Merged
jrfnl added a commit to jrfnl/TGM-Plugin-Activation that referenced this issue Jan 13, 2015
@jrfnl
Prevent duplicate error messages showing
3d68acb 
Quite a few themes and plugins which don't have their settings pages under 'options-general' also use settings_errors() to display their notices to the user.

This resulted in the TGMPA messages being shown twice on those pages as reported in TGMPA#237.

This PR fixes that.

Related: https://core.trac.wordpress.org/ticket/31000
@jrfnl jrfnl mentioned this issue Jan 13, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@GaryJones @jrfnl @manake