Fix 1387 (aboutcode-org#1389)

* Fix issue 1387 Reference: aboutcode-org#1387 Signed-off-by: Tushar Goel <[email protected]> * Add tests Signed-off-by: Tushar Goel <[email protected]> --------- Signed-off-by: Tushar Goel <[email protected]>
TG1999 · Jul 19, 2024 · f1701e0 · f1701e0
1 parent 0c22b0c
commit f1701e0
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/vulnerabilities/models.py b/vulnerabilities/models.py
@@ -37,6 +37,8 @@
 from rest_framework.authtoken.models import Token
 from univers import versions
 from univers.version_range import RANGE_CLASS_BY_SCHEMES
+from univers.version_range import AlpineLinuxVersionRange
+from univers.versions import Version
 
 from vulnerabilities import utils
 from vulnerabilities.severity_systems import SCORING_SYSTEMS
@@ -645,7 +647,11 @@ def sort_by_version(self, packages):
 
     @property
     def version_class(self):
-        return RANGE_CLASS_BY_SCHEMES[self.type].version_class
+        RANGE_CLASS_BY_SCHEMES["alpine"] = AlpineLinuxVersionRange
+        range_class = RANGE_CLASS_BY_SCHEMES.get(self.type)
+        if not range_class:
+            return Version
+        return range_class.version_class
 
     @property
     def current_version(self):

diff --git a/vulnerabilities/tests/test_models.py b/vulnerabilities/tests/test_models.py
@@ -407,8 +407,8 @@ def test_univers_version_class(self):
         pypi_package_version = RANGE_CLASS_BY_SCHEMES[pypi_package.type].version_class
         assert pypi_package_version == versions.PypiVersion
 
-        RANGE_CLASS_BY_SCHEMES["alpine"] = AlpineLinuxVersionRange
-        alpine_version = RANGE_CLASS_BY_SCHEMES["alpine"].version_class
+        alpine_package = models.Package.objects.create(type="alpine", name="lxml", version="0.9")
+        alpine_version = RANGE_CLASS_BY_SCHEMES[alpine_package.type].version_class
         assert alpine_version == versions.AlpineLinuxVersion
 
     def test_sort_by_version(self):