Improve iCal endpoint #385

Minei3oat · 2024-12-10T00:20:26Z

This PR adds two features to the iCal endpoint:

use ctf id and pad domain as persistent UID
- currently a UUID is generated for each request
- the spec requires the UID to be persistent
add ctftime_url as ATTACH
- this allows to retrieve more information about the ctf from ctftime

api/src/routes/ical.ts

JJ-8 · 2024-12-11T17:19:31Z

Hi @Minei3oat, thank you for your contribution! I have not tested your code yet but I added one question to my review, please see above. Thanks!

api/src/routes/ical.ts

This removes a redundant space.

Minei3oat added 3 commits December 10, 2024 01:01

Calendar: Use ctf id as persistent UID

9502b66

Calendar: Add ctftime_url as attachment

7ca8c2d

Calendar: Add pad domain to ensure global uniqueness

4e56a02

JJ-8 reviewed Dec 11, 2024

View reviewed changes

api/src/routes/ical.ts Outdated Show resolved Hide resolved

Calendar: Add ctftime event id and default for empty pad domain

4d12bd9

JJ-8 reviewed Dec 13, 2024

View reviewed changes

api/src/routes/ical.ts Outdated Show resolved Hide resolved

Minei3oat and others added 2 commits December 15, 2024 00:52

Calendar: Fix ATTACH:null on missing ctftime_url

5e110fe

Run prettier on ical.ts

b597556

This removes a redundant space.

JJ-8 self-requested a review December 16, 2024 10:10

JJ-8 approved these changes Dec 16, 2024

View reviewed changes

JJ-8 merged commit 559d33e into TFNS:main Dec 16, 2024
4 checks passed

Minei3oat deleted the improve-calendar branch December 16, 2024 11:57

Provide feedback