-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: change some internal fields to ten_value_t and implement loop_all_fields functions #184
Merged
halajohn
merged 17 commits into
main
from
105-use-ten_value_t-uniformly-to-represent-each-field-in-the-message
Oct 29, 2024
Merged
refactor: change some internal fields to ten_value_t and implement loop_all_fields functions #184
halajohn
merged 17 commits into
main
from
105-use-ten_value_t-uniformly-to-represent-each-field-in-the-message
Oct 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… fileds functions
…ach-field-in-the-message
This pull request includes several changes primarily focused on refactoring and improving the consistency of the codebase. The changes include renaming functions for clarity, adding new API functions, and updating field names and processing methods in various files. Function Renaming and Refactoring:
API Additions:
Field and Method Updates:
Miscellaneous Changes:
These changes aim to improve code readability, maintainability, and consistency across the codebase. |
sunxilin
commented
Oct 21, 2024
core/src/ten_runtime/msg/cmd_base/cmd/start_graph/field/extension_info.c
Outdated
Show resolved
Hide resolved
halajohn
reviewed
Oct 21, 2024
core/include_internal/ten_runtime/msg/cmd_base/cmd/start_graph/cmd.h
Outdated
Show resolved
Hide resolved
…ach-field-in-the-message
…niformly-to-represent-each-field-in-the-message
…ach-field-in-the-message
…ach-field-in-the-message
…ach-field-in-the-message
…ach-field-in-the-message
halajohn
approved these changes
Oct 29, 2024
halajohn
deleted the
105-use-ten_value_t-uniformly-to-represent-each-field-in-the-message
branch
October 29, 2024 12:35
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor: change some internal fields to ten_value_t & implement loop fields functions