Behavior functions are being called with the wrong this.
#37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This breaks behaviors that assume that their `this` is `CETEI`; there is one like that in `defaultBehavoirs`: endnotes. (This will auto-fix in ``/tutorial/js/CETEI.js` once results of the `npm` build are checked in - which seems to have not been happening for a while in `/tutorial`...) resolves #36
dubinsky
added a commit
to opentorah/alter-rebbe.org
that referenced
this pull request
Jun 18, 2020
…ions; - switch to the current CETEIcean; - remove old `CETEI.js`;
dubinsky
added a commit
to opentorah/alter-rebbe.org
that referenced
this pull request
Jun 18, 2020
- fix (locally; see TEIC/CETEIcean#37) wrong …
dubinsky
changed the title
this.this.
|
The point of the refactoring @raffazizzi did was to introduce better code isolation (so, e.g. behaviors wouldn't have the full set of CETEI methods available to them. It seems a bit sad to break that. But on the other hand, it does seem like the CETEI DOM ought to be available to behaviors. I'm about to release a patch that does just that. Thanks for bringing this to our attention! |
dubinsky
added a commit
to opentorah/alter-rebbe.org
that referenced
this pull request
Jun 21, 2020
…ions; - switch to the current CETEIcean; - remove old `CETEI.js`;
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This breaks behaviors that assume that their
thisisCETEI;there is one like that in
defaultBehavoirs: endnotes.(This will auto-fix in ``/tutorial/js/CETEI.js
once results of thenpm` build are checked in - which seems to have not been happening for a while in `/tutorial`...)