Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace dialog with dynamic card #71

Merged
merged 12 commits into from
May 3, 2022
Merged

Replace dialog with dynamic card #71

merged 12 commits into from
May 3, 2022

Conversation

bkbilly
Copy link
Contributor

@bkbilly bkbilly commented May 2, 2022

The popup window had issues when used with other cards, so I replaced it.
Now the card changes dynamically based on events which makes it simpler to use.

Keep in mind that this is a major change, so I would recommend to check out for any bugs, though on my tests it works great.

Updates:

@TECH7Fox
Copy link
Owner

TECH7Fox commented May 2, 2022

Looks good, but the audioVisualizer isn't centered relative to the card.
image

Also, I think some people still prefer the dialog because it gives more space for video and buttons, and works fine when you have a separate dashboard for it. So how about a option to set this inside a <ha-dialog> element?

And when I go back, the extension color becomes red, but there is no unregister in the log. Guess because it reloads the CSS as well?

@bkbilly
Copy link
Contributor Author

bkbilly commented May 2, 2022

I just fixed the extension color. It was one of my recent changes that broke it.
The audioVisualizer seems a bit more complicated than what I thought, but I will try to fix it.

It's a good idea to have both the ha-dialog, and the dynamic card, but it can make things much more complicated.
For now, one option is to write on README a section that explains how the previous versions work in respect with the newer.
This can give people the option to choose which one they like and then we can implement both.

@bkbilly
Copy link
Contributor Author

bkbilly commented May 2, 2022

I've fixed the audioVisualizer and I've also removed the video components if the video is disabled.
As for the dialog window, I don't think it is necessary because you can create a new view and select the type Panel as you can see a preview bellow.

image

@TECH7Fox
Copy link
Owner

TECH7Fox commented May 2, 2022

As for the dialog window, I don't think it is necessary because you can create a new view and select the type Panel as you can see a preview bellow.

Ah that's a good idea. But then we will need to increase the card size to span accross the entire panel, otherwise the video will be that small space. With the dialog it could stretch.

Will also do some more testing with video.

@bkbilly
Copy link
Contributor Author

bkbilly commented May 2, 2022

I fixed a bug with the remoteAudio and I added the feature for calling any number from here #69.

@TECH7Fox TECH7Fox changed the base branch from main to develop May 3, 2022 18:20
@TECH7Fox
Copy link
Owner

TECH7Fox commented May 3, 2022

@bkbilly I made some CSS changes, could you test? Video should now fit correctly, the bottom will go over it, and in "panel mode" the popup should stretch over the entire page.

@bkbilly
Copy link
Contributor Author

bkbilly commented May 3, 2022

I've tested it and everything seems to be working great!
I believe that this can be the next release.

I have some ideas for the future releases, though they are not that important.
I am just gonna mention them here:

  • Option to choose between wss and ws.
  • Extensions person should be optional so that other users can register if they are not in the list.
  • Option to hide other extensions.
  • For custom edit entities, it should call the number by pressing enter key.

@TECH7Fox
Copy link
Owner

TECH7Fox commented May 3, 2022

Thanks, will merge then.

Option to choose between wss and ws.

Option to use ws wouldn't work, because browsers don't accept that anymore for security reasons.

Extensions person should be optional so that other users can register if they are not in the list.

We could make a default option for a extension, so when the person isn't found, it will use that one?

Option to hide other extensions.

Another extension option, that would always hide that extension?

@TECH7Fox TECH7Fox merged commit c9e70ab into TECH7Fox:develop May 3, 2022
@TECH7Fox
Copy link
Owner

TECH7Fox commented May 3, 2022

Made the new version: https://github.com/TECH7Fox/sip-hass-card/releases/tag/v2.2.0

Thanks @bkbilly! 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants