[#12679] Solved the problem of space detection, and can prompt an error for illegal space input #13178
+13
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ON_NAME_MAX_LENGTH
Yokyeee1114
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12679
Outline of Solution
My teammates and I analyzed and discussed the ts file for detecting the input of newfeedbacksessionname.
We found that the field was not checked for validity before the copy button was pressed.
We have now added a series of methods such as trim() to determine whether there are illegal spaces in the field.
Before:
After:
we can see the warning message has been showed if the input is invalid