-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#12900] Gradle task componentTests should not stop entirely when only one task fails #12963
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's just a bit of feedback.
Co-authored-by: Jay Aljelo Ting <[email protected]>
Co-authored-by: Jay Aljelo Ting <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Thank you for the approval, let me know if I need to test or add anything else |
Hi @emrekenar, could you also help to make the change to the |
Hi @weiquu I made the change, it seems to be working fine. Let me know if there is anything else I can do. |
@weiquu Just a reminder to review this. It looks fine to me now. I think your comment has been addressed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #12900
Outline of Solution
After the docker is started, running the code below stops if
integrationTests
task fails../gradlew componentTests
However, running the following command prevents stopping before all
componentTests
tasks finish../gradlew componentTests --continue
Note that if
unitTests
task is completed before, to run it again, either the build folder should be cleaned with./gradlew clean
or--rerun-tasks
flag should be passed as well.Also note that
./gradlew componentTests jacocoReport --continue
doesn't work. Instead,./gradlew jacocoReport
command should be executed separately.In this commit, the
--continue
flag is added in github workflows and the documentation is updated.