Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#12900] Gradle task componentTests should not stop entirely when only one task fails #12963

Merged
merged 8 commits into from
May 12, 2024

Conversation

emrekenar
Copy link
Contributor

Fixes #12900

Outline of Solution

After the docker is started, running the code below stops if integrationTests task fails.

./gradlew componentTests

However, running the following command prevents stopping before all componentTests tasks finish.

./gradlew componentTests --continue

Note that if unitTests task is completed before, to run it again, either the build folder should be cleaned with ./gradlew clean or --rerun-tasks flag should be passed as well.

Also note that ./gradlew componentTests jacocoReport --continue doesn't work. Instead, ./gradlew jacocoReport command should be executed separately.

In this commit, the --continue flag is added in github workflows and the documentation is updated.

Copy link
Contributor

@jayasting98 jayasting98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's just a bit of feedback.

docs/development.md Outdated Show resolved Hide resolved
docs/development.md Outdated Show resolved Hide resolved
@jayasting98 jayasting98 added s.Ongoing The PR is being worked on by the author(s) c.Task Other non-user-facing works, e.g. refactoring, adding tests labels Apr 2, 2024
@ziqing26 ziqing26 added s.ToReview The PR is waiting for review(s) and removed s.Ongoing The PR is being worked on by the author(s) labels Apr 9, 2024
Copy link
Contributor

@jayasting98 jayasting98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jayasting98 jayasting98 added s.FinalReview The PR is ready for final review and removed s.ToReview The PR is waiting for review(s) labels Apr 11, 2024
@emrekenar
Copy link
Contributor Author

Thank you for the approval, let me know if I need to test or add anything else

@weiquu
Copy link
Contributor

weiquu commented Apr 21, 2024

Hi @emrekenar, could you also help to make the change to the /.github/workflows/jdk21.yml file? Should be line 34. Thanks!

@emrekenar
Copy link
Contributor Author

Hi @weiquu I made the change, it seems to be working fine. Let me know if there is anything else I can do.

@jayasting98
Copy link
Contributor

@weiquu Just a reminder to review this. It looks fine to me now. I think your comment has been addressed.

Copy link
Contributor

@weiquu weiquu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weiquu weiquu added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging and removed s.FinalReview The PR is ready for final review labels May 11, 2024
@weiquu weiquu merged commit 1ea04f4 into TEAMMATES:master May 12, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c.Task Other non-user-facing works, e.g. refactoring, adding tests s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gradle task componentTests should not stop entirely when only one task fails
4 participants