-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#12312] Instructor giving individual deadline extensions: give an easy way to select all those who have not submitted yet #12420
Conversation
Hi @ellaella12, thank you for your interest in contributing to TEAMMATES!
Please address the above before we proceed to review your PR. |
Thank you for working on this! Some suggestions:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the changes!
Folks, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Fixes #12312
Outline of Solution
I was also wondering, why is isLoadingAllStudents set to false, right when the feedback session is loaded and before getAllStudentsOfCourse()?
New deadline extension is applied to all instructors and users that have not submitted.