Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#12312] Instructor giving individual deadline extensions: give an easy way to select all those who have not submitted yet #12420

Conversation

undermyumbrella1
Copy link
Contributor

@undermyumbrella1 undermyumbrella1 commented May 6, 2023

Fixes #12312

Outline of Solution

  • queries feedback service to get submitted giver set
  • updates submit status in Feedback model
    I was also wondering, why is isLoadingAllStudents set to false, right when the feedback session is loaded and before getAllStudentsOfCourse()?

New deadline extension is applied to all instructors and users that have not submitted.
image
image
image

@github-actions
Copy link

github-actions bot commented May 6, 2023

Hi @ellaella12, thank you for your interest in contributing to TEAMMATES!
However, your PR does not appear to follow our contribution guidelines:

  • Title must start with the issue number the PR is fixing in square brackets, e.g. [#<issue-number>]

Please address the above before we proceed to review your PR.

@undermyumbrella1 undermyumbrella1 changed the title [12312] Instructor giving individual deadline extensions: give an easy way to select all those who have not submitted yet [#12312] Instructor giving individual deadline extensions: give an easy way to select all those who have not submitted yet May 6, 2023
@domlimm domlimm added the s.ToReview The PR is waiting for review(s) label May 7, 2023
@zhaojj2209
Copy link
Contributor

Thank you for working on this!

Some suggestions:

  • Use the form-check class for the styling of the checkbox, do check the discussion in [#12313] Instructor sending submission reminders: missing space between checkbox and label #12366 for more details.
  • The new checkboxes work, but the "Select All" checkboxes are not updated accordingly (see below screenshot where clicking the "Select all instructors not yet submitted" checkbox causes all instructors to be selected, but the "Select All" checkbox is not ticked). Can we add in logic to update these checkboxes as well when interacting with the new checkboxes?
Screenshot 2023-05-12 at 19 38 01

@undermyumbrella1
Copy link
Contributor Author

Thank you for the review, I have updated the code to include form-check bootstrap class, and added logic to update 'Select All' checkbox, Thank you!
image

Copy link
Contributor

@zhaojj2209 zhaojj2209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the changes!

@zhaojj2209 zhaojj2209 added s.FinalReview The PR is ready for final review and removed s.ToReview The PR is waiting for review(s) labels May 14, 2023
@nusoss-bot
Copy link

Folks, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢
Hope someone can get it to move forward again soon...

Copy link
Contributor

@weiquu weiquu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@weiquu weiquu merged commit 4b2333d into TEAMMATES:master May 22, 2023
@samuelfangjw samuelfangjw added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging c.Feature User-facing feature; can be new feature or enhancement to existing feature and removed s.FinalReview The PR is ready for final review labels Jul 14, 2023
@samuelfangjw samuelfangjw added this to the V8.28.0 milestone Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c.Feature User-facing feature; can be new feature or enhancement to existing feature s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
6 participants