[#12344] Instructor courses page: fix margin of copy instructors from other courses modal on mobile #12389
Conversation
|
Hi @b-walton, solution looks fine at a glance, but do fix the lint issues before we do a complete review. |
There was a problem hiding this comment.
Hi @b-walton, while this solution works, I think we should implement it in a way that is consistent with the rest of the modals. In particular, you can take a look at the copy-questions-from-other-sessions-modal component to see what I mean (involves setting min-width instead). Do let me know if you require any clarification.
Don't forget to update your branch with the latest changes, and re-request a review when you're ready!
|
Are there any likely reasons for why the E2E tests fail? |
Hmm E2E tests can fail (for frontend changes) if there are changes to page structure / behaviour / element identifiers. However, they might occasionally fail due to the tests being unstable, in which case we will run them again (: Your PR passes all checks, so no worries there. |
weiquu
added
s.FinalReview
zhaojj2209
added
s.ToMerge
Fixes #12344
Outline of Solution
Fixes mobile margin by only applying width constraint on media 768 pixels or wider.
(ready for review)
Desktop View:
Mobile View:
