Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#12288] Admin notifications page: Fix notifications table overflow #12386

Merged
merged 6 commits into from
Apr 20, 2023
Merged

[#12288] Admin notifications page: Fix notifications table overflow #12386

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6badd0b
Fix admin notifications table overflow
yujioshiro Apr 17, 2023
4085596
Fix admin notifications table overflow
yujioshiro Apr 19, 2023
aa753c3
Fix admin notifications table overflow
yujioshiro Apr 19, 2023
64904ca
Merge branch 'master' into 12288-admin-notifications-table-overflow
yujioshiro Apr 19, 2023
28a4c5b
Fix admin notifications table overflow and run snapshot test
yujioshiro Apr 19, 2023
9c6c9b5
Merge branch 'master' into 12288-admin-notifications-table-overflow
yujioshiro Apr 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...cations-page/notifications-table/__snapshots__/notifications-table.component.spec.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ exports[`NotificationsTableComponent should snap like in notification page with
class="row"
>
<div
class="col-12"
class="col-12 table-responsive"
>
<table
class="table table-responsive-lg table-striped table-bordered margin-bottom-0"
Expand Down Expand Up @@ -295,7 +295,7 @@ exports[`NotificationsTableComponent should snap like in notification page with
class="row"
>
<div
class="col-12"
class="col-12 table-responsive"
>
<table
class="table table-responsive-lg table-striped table-bordered margin-bottom-0"
Expand Down Expand Up @@ -570,7 +570,7 @@ exports[`NotificationsTableComponent should snap with default fields 1`] = `
class="row"
>
<div
class="col-12"
class="col-12 table-responsive"
>
<table
class="table table-responsive-lg table-striped table-bordered margin-bottom-0"
Expand Down
2 changes: 1 addition & 1 deletion ...ges-admin/admin-notifications-page/notifications-table/notifications-table.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<div class="row">
<div class="col-12">
<div class="col-12 table-responsive">
<table id="notifications-table" class="table table-responsive-lg table-striped table-bordered margin-bottom-0">
<thead>
<tr [ngClass]="{ 'bg-primary text-white': headerColorScheme === NotificationsTableHeaderColorScheme.BLUE }">
Expand Down
4 changes: 4 additions & 0 deletions ...ges-admin/admin-notifications-page/notifications-table/notifications-table.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,3 +36,7 @@
.padding-left-7px {
padding-left: 7px;
}

#notifications-table {
min-width: 650px;
}