[#4570] Instructor: support previewing results as a student #12351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently preview shows exactly what the person being previewed sees. The next step is to remove/modify results that shouldn't be visible to the person previewing the results.
Fix code style, update preview results info, update test and snapshot
Tests for loading comments are missing
…4570-preview-results-as-student
# Conflicts: # src/web/app/components/question-response-panel/__snapshots__/question-response-panel.component.spec.ts.snap # src/web/app/components/question-response-panel/question-response-panel.component.html # src/web/app/pages-instructor/instructor-session-result-page/instructor-session-result-page.component.ts # src/web/app/pages-session/session-result-page/session-result-page.component.spec.ts # src/web/app/pages-session/session-result-page/session-result-page.component.ts
wkurniawan07
force-pushed
the
4570-revamp
branch
2 times, most recently
from
707c814
to
95e919b
Compare
wkurniawan07
force-pushed
the
4570-revamp
branch
from
95e919b
to
34ef23a
Compare
wkurniawan07
force-pushed
the
4570-revamp
branch
from
34ef23a
to
e49dd22
Compare
wkurniawan07
added
s.FinalReview
zhaojj2209
approved these changes
Apr 8, 2023
samuelfangjw
added
s.ToMerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4570
Continuing work done from #11859; the original PR was actually only a handful of changes away from being ready to merge.