Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#12081] Fix rank recipients question mobile spacing #12299

Merged
merged 4 commits into from
Mar 30, 2023
Merged

[#12081] Fix rank recipients question mobile spacing #12299

merged 4 commits into from
Mar 30, 2023

Conversation

jasonqiu212
Copy link
Contributor

@github-actions
Copy link

Hi @jasonqiu212, thank you for your interest in contributing to TEAMMATES!
However, your PR does not appear to follow our contribution guidelines:

  • Title must start with the issue number the PR is fixing in square brackets, e.g. [#<issue-number>]

Please address the above before we proceed to review your PR.

@jasonqiu212 jasonqiu212 changed the title 12081 fix rank recipient [#12081] Fix rank recipients question mobile spacing Mar 29, 2023
weiquu
weiquu reviewed Mar 30, 2023
View reviewed changes
Copy link
Contributor

@weiquu weiquu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix looks good! Just one small thing that we might as well fix now

...n-types/question-edit-details-form/rank-recipients-question-edit-details-form.component.html Outdated Show resolved Hide resolved
@weiquu weiquu added the s.ToReview The PR is waiting for review(s) label Mar 30, 2023
zhaojj2209
zhaojj2209 approved these changes Mar 30, 2023
View reviewed changes
Copy link
Contributor

@zhaojj2209 zhaojj2209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zhaojj2209 zhaojj2209 added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging and removed s.ToReview The PR is waiting for review(s) labels Mar 30, 2023
@zhaojj2209 zhaojj2209 merged commit 050daa7 into TEAMMATES:master Mar 30, 2023
@zhaojj2209 zhaojj2209 added the c.Bug Bug/defect report label Apr 2, 2023
@zhaojj2209 zhaojj2209 added this to the V8.26.0 milestone Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weiquu weiquu weiquu left review comments

@zhaojj2209 zhaojj2209 zhaojj2209 approved these changes

Assignees

@weiquu weiquu

@zhaojj2209 zhaojj2209

Labels
c.Bug Bug/defect report s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Milestone
V8.26.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jasonqiu212 @weiquu @zhaojj2209