Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#12278] Instructor home page: Fix alignment of "Add New Course" button #12295

Merged
merged 3 commits into from
Mar 29, 2023
Merged

[#12278] Instructor home page: Fix alignment of "Add New Course" button #12295

merged 3 commits into from
Mar 29, 2023

Conversation

meet0806
Copy link
Contributor

@meet0806 meet0806 commented Mar 28, 2023 •
edited
Loading

Fixes #12278

PR Checklist

Ensure that you have:

  • Read and understood our PR guideline: https://teammates.github.io/teammates/process.html#step-4-submit-a-pr
    • Added the issue number to the "Fixes" keyword above
    • Titled the PR as specified in the abovementioned document
  • Made your changes on a branch other than master and release
  • Gone through all the changes in this PR and ensured that:
    • They addressed one (and only one) issue
    • No unintended changes were made
  • Run and passed static analysis: ./gradlew lint and npm run lint
  • Added/updated tests, if changes in functionality were involved
  • Added/updated documentation to public APIs (classes, methods, variables), if applicable

Outline of Solution

weiquu
weiquu approved these changes Mar 28, 2023
View reviewed changes
Copy link
Contributor

@weiquu weiquu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for quick changes

@weiquu weiquu requested a review from domlimm March 28, 2023 18:19
@weiquu weiquu added the s.ToReview The PR is waiting for review(s) label Mar 28, 2023
@meet0806 meet0806 mentioned this pull request Mar 29, 2023
Closed
10 tasks
domlimm
domlimm approved these changes Mar 29, 2023
View reviewed changes
Copy link
Contributor

@domlimm domlimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@meet0806 LGTM! Thank you for your contribution and making the quick fixes!

@domlimm domlimm added s.FinalReview The PR is ready for final review and removed s.ToReview The PR is waiting for review(s) labels Mar 29, 2023
@domlimm domlimm requested a review from zhaojj2209 March 29, 2023 05:39
@zhaojj2209 zhaojj2209 added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging and removed s.FinalReview The PR is ready for final review labels Mar 29, 2023
@zhaojj2209 zhaojj2209 merged commit 0734762 into TEAMMATES:master Mar 29, 2023
@meet0806
Copy link
Contributor Author

Thank you @domlimm @weiquu @zhaojj2209 for reviewing changes and merging.

@zhaojj2209 zhaojj2209 added the c.Bug Bug/defect report label Apr 2, 2023
@zhaojj2209 zhaojj2209 added this to the V8.26.0 milestone Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhaojj2209 zhaojj2209 zhaojj2209 approved these changes

@weiquu weiquu weiquu approved these changes

@domlimm domlimm domlimm approved these changes

Assignees

@domlimm domlimm

@weiquu weiquu

Labels
c.Bug Bug/defect report s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Milestone
V8.26.0
Development

Successfully merging this pull request may close these issues.

Instructor home page: Fix alignment of "Add New Course" button
4 participants
@meet0806 @domlimm @weiquu @zhaojj2209