[#12125] Instructor results page stats tables: differentiate students with same team and name #12249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do fix the failing E2E tests and update your branch with the changes from the master branch. Approach looks alright for now, we will do a more thorough review once the branch has been updated. In the meantime, it would be good if you can add screenshots showing your fix, so as to help speed up the review process. Do also check if the same changes are present in the downloaded CSV data as well. |
samuelfangjw
added
s.Ongoing
|
Hi I have updated the pr to pass the e2e tests, merge main into this branch, and added screenshots in the pull request. May I request for some help reviewing the pr? Thank you! |
cedricongjh
reviewed
Apr 6, 2023
...ts/question-responses/per-question-view-responses/per-question-view-responses.component.html
Show resolved
Hide resolved
samuelfangjw
added
s.ToReview
cedricongjh
approved these changes
Apr 7, 2023
samuelfangjw
added
s.ToMerge
samuelfangjw
added
the
c.Feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12125
My attempt at adding email to statistics table. Not sure if I am supposed to modify the statistics-calculation files and subsequently the response.json test fiiles.
The emails was already included in the csv files before this feature
