[#11383] Fix PR checking workflow permissions #12215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hhdqirui
approved these changes
Mar 16, 2023
samuelfangjw
approved these changes
Mar 16, 2023
zhaojj2209
added
s.ToMerge
samuelfangjw
added
the
c.DevOps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #11383
The PR checking workflow is currently running into permissions issues. This is because Github provides read-only tokens to all forks for security reasons.
To fix this, the workflow trigger has been changed from
pull_requesttopull_request_target, so that the workflow is run on the target branchmasterwhere write permissions can be provided. Permissions have been limited to write permissions for PRs only for security reasons.Note that this workflow will now only run after the changes are merged into
master, hence testing of the workflow is not possible in this PR. I have opened a PR in my own fork to test this fix, at zhaojj2209#39.In the future, if I have the capacity, I may expand this workflow to include other actions such as labelling PRs.