-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#12081] User-friendliness: Fix feedback path dropdown #12207
[#12081] User-friendliness: Fix feedback path dropdown #12207
Conversation
…riendliness-second
I didn't put Given this situation, should I remove the |
I think in this case it would be alright to remove the aria label. Also, do fix the E2E tests, this PR seems to have broken a few. |
Snyk is currently down which explains the failing test. |
Thanks, updated! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the fix!
* Shift submenu to bottom * Clean up code * Change to buttons for accessibility and update chevron * Fix screenreader focus * Lint and test * Fix mobile overflow * Fix lint issues * Remove aria-label and update tests * Fix attempt for E2E tests * Update tests * Refine E2E change
* Shift submenu to bottom * Clean up code * Change to buttons for accessibility and update chevron * Fix screenreader focus * Lint and test * Fix mobile overflow * Fix lint issues * Remove aria-label and update tests * Fix attempt for E2E tests * Update tests * Refine E2E change
* Shift submenu to bottom * Clean up code * Change to buttons for accessibility and update chevron * Fix screenreader focus * Lint and test * Fix mobile overflow * Fix lint issues * Remove aria-label and update tests * Fix attempt for E2E tests * Update tests * Refine E2E change
* Shift submenu to bottom * Clean up code * Change to buttons for accessibility and update chevron * Fix screenreader focus * Lint and test * Fix mobile overflow * Fix lint issues * Remove aria-label and update tests * Fix attempt for E2E tests * Update tests * Refine E2E change
Part of #12081
Sub-issue: Fix feedback path dropdown
Outline of Solution
Changed second dropdown to be below instead of to the side. Keeps track of which submenus are open via a map. Also added buttons for accessibility and added the
text-wrap
class to resolve overflow issues.For E2E tests, changed the options to click on the button.