Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#12081] User-friendliness: Make submit feedback rubric table cell clickable #12205

Merged
merged 1 commit into from
Mar 14, 2023
Merged

[#12081] User-friendliness: Make submit feedback rubric table cell clickable #12205

merged 1 commit into from
Mar 14, 2023

Conversation

jasonqiu212
Copy link
Contributor

Part of #12081
Sub-issue Submit feedback response page: rubric question

Outline of Solution

  • Problem: Nested elements inside <td> triggers click event twice due to bubbling
  • Solution:
    • Segregate out nested elements
    • Generate unique id for each table cell's input, so that the label can explicitly label its corresponding input

zhaojj2209
zhaojj2209 approved these changes Mar 14, 2023
View reviewed changes
Copy link
Contributor

@zhaojj2209 zhaojj2209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@zhaojj2209 zhaojj2209 added the s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging label Mar 14, 2023
@zhaojj2209 zhaojj2209 merged commit c70a73c into TEAMMATES:user-friendliness Mar 14, 2023
zhaojj2209 pushed a commit that referenced this pull request Mar 23, 2023
@jasonqiu212 @zhaojj2209
Create unique id for rubric table cell (#12205)
ceccf59
zhaojj2209 pushed a commit that referenced this pull request Mar 23, 2023
@jasonqiu212 @zhaojj2209
[#12081] Create unique id for rubric table cell (#12205)
109645d
zhaojj2209 pushed a commit that referenced this pull request Mar 25, 2023
@jasonqiu212 @zhaojj2209
[#12081] Create unique id for rubric table cell (#12205)
d8ad6c6
zhaojj2209 pushed a commit that referenced this pull request Mar 25, 2023
@jasonqiu212 @zhaojj2209
[#12081] Create unique id for rubric table cell (#12205)
27c5507
@jasonqiu212 jasonqiu212 deleted the 12081-submit-feedback-rubric-clickable-cell branch March 26, 2023 18:04
@zhaojj2209 zhaojj2209 self-assigned this Apr 2, 2023
@zhaojj2209 zhaojj2209 added the c.Bug Bug/defect report label Apr 2, 2023
@zhaojj2209 zhaojj2209 added this to the V8.26.0 milestone Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhaojj2209 zhaojj2209 zhaojj2209 approved these changes

@weiquu weiquu Awaiting requested review from weiquu

Assignees

@zhaojj2209 zhaojj2209

Labels
c.Bug Bug/defect report s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Milestone
V8.26.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jasonqiu212 @zhaojj2209