Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#12081] User-friendliness: Display card header content in column format for mobile #12197

Conversation

jasonqiu212
Copy link
Contributor

Part of #12081
Sub-issue View responses page: Modify header of each card to display content in column instead of row format on mobile

Outline of Solution

  • Use flex-column by default to make header display content in column (Mobile)
  • Use flex-sm-row to make header display content in row (Desktop)

Copy link
Contributor

@weiquu weiquu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM!

Copy link
Contributor

@zhaojj2209 zhaojj2209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zhaojj2209 zhaojj2209 added the s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging label Mar 13, 2023
@zhaojj2209 zhaojj2209 merged commit 4b6d45a into TEAMMATES:user-friendliness Mar 13, 2023
@jasonqiu212 jasonqiu212 deleted the 12081-display-header-card-header-column-mobile branch March 26, 2023 18:04
@zhaojj2209 zhaojj2209 added the c.Bug Bug/defect report label Apr 2, 2023
@zhaojj2209 zhaojj2209 added this to the V8.26.0 milestone Apr 2, 2023
@zhaojj2209 zhaojj2209 added c.Feature User-facing feature; can be new feature or enhancement to existing feature and removed c.Bug Bug/defect report labels Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c.Feature User-facing feature; can be new feature or enhancement to existing feature s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants