User-friendliness: Add labels and change "more info" button for team contribution questions #12153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhaojj2209
added
the
s.ToMerge
zhaojj2209
pushed a commit
that referenced
this pull request
Mar 23, 2023
…contribution questions (#12153) * Add labels and change button * Update tests
zhaojj2209
pushed a commit
that referenced
this pull request
Mar 23, 2023
…for team contribution questions (#12153) * Add labels and change button * Update tests
zhaojj2209
pushed a commit
that referenced
this pull request
Mar 25, 2023
…for team contribution questions (#12153) * Add labels and change button * Update tests
zhaojj2209
pushed a commit
that referenced
this pull request
Mar 25, 2023
…for team contribution questions (#12153) * Add labels and change button * Update tests
zhaojj2209
added
the
c.Feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #12081
Sub-issue: Labels and "more info" button for team contribution question
Outline of Solution
Add labels similar to previous question types. Also changed the position of the "more info" button as I think that it makes more sense to come under question instructions. In addition, since
tabindexis a global attribute, to allow for the button to come first while in its current position, there would be a need to add/change thetabindexof many elements on the page. Moving the "more info" button solves this problem.I also altered the CSS a little to take into account the move. See below for a comparison.
Previously (v4):
After the change:
