Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#12048] AccountRequest Actions Migration #12141

Merged
merged 18 commits into from
Mar 6, 2023
Merged

[#12048] AccountRequest Actions Migration #12141

merged 18 commits into from
Mar 6, 2023

Conversation

kevin9foong
Copy link
Member

@kevin9foong kevin9foong commented Feb 27, 2023 •
edited
Loading

Outline of Solution
Migrating and abstracting AccountRequest actions to use the new sql logic

Works completed:

  • integration tests for logic component.
  • Created actions which use SQL for create, delete, get and reset AccountRequests.

@kevin9foong kevin9foong changed the base branch from master to v9-migration February 27, 2023 06:09
@samuelfangjw samuelfangjw changed the title AccountRequest Actions Migration [#12048] AccountRequest Actions Migration Feb 27, 2023
@kevin9foong kevin9foong marked this pull request as draft February 27, 2023 06:27
@kevin9foong kevin9foong changed the title [#12048] AccountRequest Actions Migration [#12048] [Ongoing] AccountRequest Actions Migration Feb 27, 2023
@kevin9foong kevin9foong changed the title [#12048] [Ongoing] AccountRequest Actions Migration [#12048] AccountRequest Actions Migration Feb 27, 2023
@kevin9foong kevin9foong marked this pull request as ready for review February 27, 2023 08:04
daongochieu2810
daongochieu2810 requested changes Feb 27, 2023
View reviewed changes
Copy link
Contributor

@daongochieu2810 daongochieu2810 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may want to disable the failing component tests for now

src/main/java/teammates/sqllogic/core/AccountRequestsLogic.java Outdated Show resolved Hide resolved
src/main/java/teammates/ui/output/AccountRequestData.java Show resolved Hide resolved
src/main/java/teammates/ui/webapi/CreateAccountRequestAction.java Outdated Show resolved Hide resolved
@samuelfangjw
Copy link
Member

@kevin9foong could you help to update your branch. Quite outdated already. Can merge v9 into this branch.

@kevin9foong
Copy link
Member Author

@kevin9foong could you help to update your branch. Quite outdated already. Can merge v9 into this branch.

ok doing so now @samuelfangjw

@kevin9foong
Copy link
Member Author

@kevin9foong could you help to update your branch. Quite outdated already. Can merge v9 into this branch.

hi samuel, I believe I have merged v9 into this branch 2 hours ago, it should be up to date.

samuelfangjw
samuelfangjw approved these changes Mar 6, 2023
View reviewed changes
src/main/java/teammates/sqllogic/api/Logic.java Outdated Show resolved Hide resolved
src/main/java/teammates/sqllogic/api/Logic.java Outdated Show resolved Hide resolved
@samuelfangjw samuelfangjw merged commit ff807e9 into TEAMMATES:v9-migration Mar 6, 2023
samuelfangjw pushed a commit that referenced this pull request Apr 8, 2023
@kevin9foong @samuelfangjw
[#12048] AccountRequest Actions Migration (#12141)
74a8564
@wkurniawan07 wkurniawan07 added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging c.Task Other non-user-facing works, e.g. refactoring, adding tests labels Jan 21, 2024
@wkurniawan07 wkurniawan07 added this to the V9.0.0-beta.0 milestone Jan 21, 2024
@jayasting98 jayasting98 mentioned this pull request Mar 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelfangjw samuelfangjw samuelfangjw approved these changes

@daongochieu2810 daongochieu2810 daongochieu2810 approved these changes

Assignees
No one assigned
Labels
c.Task Other non-user-facing works, e.g. refactoring, adding tests s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Milestone
V9.0.0-beta.0
Development

Successfully merging this pull request may close these issues.
4 participants
@kevin9foong @samuelfangjw @daongochieu2810 @wkurniawan07