-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create SQL logic for GetNotificationAction and add relevant tests for v9 migration #12080
Merged
samuelfangjw
merged 19 commits into
TEAMMATES:v9-migration
from
hhdqirui:v9-migration-notification-GetNotificationAction
Feb 21, 2023
Merged
Create SQL logic for GetNotificationAction and add relevant tests for v9 migration #12080
samuelfangjw
merged 19 commits into
TEAMMATES:v9-migration
from
hhdqirui:v9-migration-notification-GetNotificationAction
Feb 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hhdqirui
force-pushed
the
v9-migration-notification-GetNotificationAction
branch
2 times, most recently
from
February 15, 2023 08:24
e6a580e
to
78c8ddd
Compare
src/test/java/teammates/storage/sqlapi/NotificationsDbTest.java
Outdated
Show resolved
Hide resolved
samuelfangjw
approved these changes
Feb 15, 2023
hhdqirui
force-pushed
the
v9-migration-notification-GetNotificationAction
branch
from
February 16, 2023 06:01
8712c55
to
afc14d8
Compare
samuelfangjw
pushed a commit
that referenced
this pull request
Feb 26, 2023
…ts for v9 migration (#12080)
samuelfangjw
pushed a commit
that referenced
this pull request
Apr 8, 2023
…ts for v9 migration (#12080)
wkurniawan07
added
s.ToMerge
The PR is approved by all reviewers including final reviewer; ready for merging
c.Task
Other non-user-facing works, e.g. refactoring, adding tests
and removed
s.ToReview
The PR is waiting for review(s)
labels
Jan 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #12048
Create SQL logic for
GetNotificationAction
and add relevant tests.