Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#12052] Per Receiver Submission #12053

Merged
merged 92 commits into from
Jan 21, 2024
Merged

[#12052] Per Receiver Submission #12053

merged 92 commits into from
Jan 21, 2024

Conversation

hhdqirui
Copy link
Member

@hhdqirui hhdqirui commented Feb 4, 2023 •
edited
Loading

Fix #12052

This PR creates the frontend UI/UX for the Per Receiver Submission project.

Outline of Solution
A dropdown list is added below the session details. Users can change the view to either the default view (group by questions) or the grouping questions by recipients view (group by recipients), by selecting the corresponding options.
image

The full default view is shown in this link: hhdqirui#8 (comment)

The full grouping questions by recipients view is shown in this link: hhdqirui#9 (comment)

hhdqirui and others added 30 commits January 26, 2023 20:04
@hhdqirui
Add logic for grouping questions by recipients
a7782b0
@hhdqirui
Fix style
efbf6ee
@hhdqirui
Fix bug
29c53a5
@domlimm
Add base of per receiver submission UI
ca44a05
@hhdqirui
Fix dropdown list
58ad6fe
@hhdqirui
Add UI for grouping questions by recipient
bf84caf
@hhdqirui
Fix logic for grouping questions by recipient
49d25e0
@hhdqirui
Remove redundant code
3258711
@hhdqirui
Fix style
adc425c
@hhdqirui
Remove redundant code
7c3847a
@domlimm
Update styling to shift position of view button
71a2f63
@domlimm
Add container to hold groupable questions
3813770
@domlimm
Add comment for clarity and clean up
8573a0a
@domlimm
Add UI logic to containerise ungroupable questions
f7047c2
@domlimm
Enhance error message and clean up log statements
430ac19
@domlimm
Add attempt for responsiveness
1eb364a
@domlimm
Clean up remove unwanted space
c29780d
@domlimm
Remove single submit response button when questions are grouped
314141a
@hhdqirui
Make UI responsive
3c3bfb1
@hhdqirui
Unduplicate tag id
3452036
@hhdqirui
Add logic to handle question submission form header colour when in gr…
53024f9 
…ouping view
@hhdqirui
Improve style
71d1946
@domlimm
Reduce size of group control container and center text
4b0be2c
@hhdqirui
Fix bug: question submission form turn green when make response in gr…
3e95c6f 
…ouping mode
@domlimm
Merge branch 'per-receiver-submission' of github.com:hhdqirui/teammat…
77642b1 
…es into per-receiver-submission
@domlimm
Add attempt to accommodate state change for session view
a4003ed
@hhdqirui
Remove unused button
0607b9d
@hhdqirui
Add logic to get recipient name in grouping questions view
50489c7
@hhdqirui
Add documentation
5012388
@hhdqirui
Fix logic to handle questions with FLEXIBLE_RECIPIENT mode in groupin…
ee62adb 
…g questions by recipients view
@hhdqirui hhdqirui marked this pull request as ready for review April 23, 2023 17:05
@hhdqirui
Copy link
Member Author

Hi @wkurniawan07 this PR is ready for review. Thank you!

@nusoss-bot
Copy link

Folks, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢
Hope someone can get it to move forward again soon...

@nusoss-bot
Copy link

Folks, This PR seems to be stalling (no activities for the past 9 days). 🐌 😢
Hope someone can get it to move forward again soon...

@nusoss-bot
Copy link

Folks, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢
Hope someone can get it to move forward again soon...

2 similar comments
@nusoss-bot
Copy link

Folks, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢
Hope someone can get it to move forward again soon...

@nusoss-bot
Copy link

Folks, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢
Hope someone can get it to move forward again soon...

@kevin9foong
Copy link
Member

hi there, just checking in if there are any updates on this?

@nusoss-bot
Copy link

Folks, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢
Hope someone can get it to move forward again soon...

@wkurniawan07
Copy link
Member

I'll take a look this weekend, apologies for the delay

@nusoss-bot
Copy link

Folks, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢
Hope someone can get it to move forward again soon...

2 similar comments
@nusoss-bot
Copy link

Folks, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢
Hope someone can get it to move forward again soon...

@nusoss-bot
Copy link

Folks, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢
Hope someone can get it to move forward again soon...

@domlimm domlimm added the s.OnHold The issue/PR's validity has been put on hold pending some other event label Jul 4, 2023
@wkurniawan07 wkurniawan07 added s.Ongoing The PR is being worked on by the author(s) and removed s.OnHold The issue/PR's validity has been put on hold pending some other event labels Jan 20, 2024
@domlimm domlimm added s.ToReview The PR is waiting for review(s) and removed s.Ongoing The PR is being worked on by the author(s) labels Jan 20, 2024
@wkurniawan07 wkurniawan07 added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging c.Feature User-facing feature; can be new feature or enhancement to existing feature and removed s.ToReview The PR is waiting for review(s) labels Jan 21, 2024
@wkurniawan07 wkurniawan07 added this to the V8.30.0 milestone Jan 21, 2024
@wkurniawan07 wkurniawan07 merged commit abae3fa into TEAMMATES:master Jan 21, 2024
9 checks passed
cedricongjh pushed a commit to cedricongjh/teammates that referenced this pull request Feb 20, 2024
@hhdqirui @cedricongjh
[TEAMMATES#12052] Per Receiver Submission (TEAMMATES#12053)
f40d915
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelfangjw samuelfangjw samuelfangjw left review comments

@zhaojj2209 zhaojj2209 zhaojj2209 left review comments

@wkurniawan07 wkurniawan07 wkurniawan07 approved these changes

Assignees

@wkurniawan07 wkurniawan07

Labels
c.Feature User-facing feature; can be new feature or enhancement to existing feature s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Milestone
V8.30.0
Development

Successfully merging this pull request may close these issues.

Create frontend for Per Receiver Submission
7 participants
@hhdqirui @samuelfangjw @wkurniawan07 @nusoss-bot @kevin9foong @zhaojj2209 @domlimm