Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#1501] Create Unit tests for FeedbackRubricQuestionDetails Class #12040

Merged
merged 4 commits into from
Feb 6, 2023
Merged

[#1501] Create Unit tests for FeedbackRubricQuestionDetails Class #12040

merged 4 commits into from
Feb 6, 2023

Conversation

vitormanoel17
Copy link
Contributor

Fixes Part of #1501

Adding unit tests for the shouldChangesRequireResponseDeletion method in the FeedbackRubricQuestionDetails Class

@fsgmhoward fsgmhoward added the s.ToReview The PR is waiting for review(s) label Jan 22, 2023
zhaojj2209
zhaojj2209 reviewed Jan 25, 2023
View reviewed changes
Copy link
Contributor

@zhaojj2209 zhaojj2209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the additional tests, just some nits.

src/test/java/teammates/common/datatransfer/questions/FeedbackRubricQuestionDetailsTest.java Outdated Show resolved Hide resolved
src/test/java/teammates/common/datatransfer/questions/FeedbackRubricQuestionDetailsTest.java Outdated Show resolved Hide resolved
@vitormanoel17
Copy link
Contributor Author

Changes made

zhaojj2209
zhaojj2209 approved these changes Jan 27, 2023
View reviewed changes
Copy link
Contributor

@zhaojj2209 zhaojj2209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhaojj2209 zhaojj2209 added s.FinalReview The PR is ready for final review and removed s.ToReview The PR is waiting for review(s) labels Jan 27, 2023
wkurniawan07
wkurniawan07 approved these changes Jan 28, 2023
View reviewed changes
Copy link
Member

@wkurniawan07 wkurniawan07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@wkurniawan07 wkurniawan07 added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging c.Task Other non-user-facing works, e.g. refactoring, adding tests and removed s.FinalReview The PR is ready for final review labels Jan 28, 2023
@wkurniawan07 wkurniawan07 added this to the V8.22.0 milestone Jan 28, 2023
@nusoss-bot
Copy link

Folks, This PR seems to be stalling (no activities for the past 8 days). 🐌 😢
Hope someone can get it to move forward again soon...

@samuelfangjw samuelfangjw changed the title [#1501] Creating some Unit tests for FeedbackRubricQuestionDetails Class [#1501] Create Unit tests for FeedbackRubricQuestionDetails Class Feb 6, 2023
@samuelfangjw samuelfangjw merged commit c27d42f into TEAMMATES:master Feb 6, 2023
weiquu added a commit to weiquu/teammates that referenced this pull request Feb 18, 2023
@weiquu
Revert "[TEAMMATES#1501] Create Unit tests for FeedbackRubricQuestion…
b69c723 
…Details Class (TEAMMATES#12040)"

This reverts commit c27d42f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhaojj2209 zhaojj2209 zhaojj2209 approved these changes

@wkurniawan07 wkurniawan07 wkurniawan07 approved these changes

Assignees

@wkurniawan07 wkurniawan07

@zhaojj2209 zhaojj2209

Labels
c.Task Other non-user-facing works, e.g. refactoring, adding tests s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Milestone
V8.22.0
Development

Successfully merging this pull request may close these issues.
6 participants
@vitormanoel17 @nusoss-bot @wkurniawan07 @zhaojj2209 @fsgmhoward @samuelfangjw